Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Unified Diff: runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart

Issue 2687143005: Include metadata in AOT to expand inline frames in stack traces and provide line numbers. (Closed)
Patch Set: collect invisible code frames Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart
diff --git a/runtime/tests/vm/dart/optimized_stacktrace_test.dart b/runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart
similarity index 84%
copy from runtime/tests/vm/dart/optimized_stacktrace_test.dart
copy to runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart
index d002a2e28b0c32c11d9830998c9206ebb6e96297..bfa7c4443b0b39f4c9ca2246a05493486bbdf553 100644
--- a/runtime/tests/vm/dart/optimized_stacktrace_test.dart
+++ b/runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart
@@ -19,8 +19,9 @@ test1() {
Expect.fail("Unreachable");
} catch (e, stacktrace) {
String s = stacktrace.toString();
- Expect.isFalse(s.contains("-1:-1"));
- Expect.isTrue(s.contains("11:18"));
+ print(s);
+ Expect.isFalse(s.contains("-1:-1"), "A");
+ Expect.isTrue(s.contains("optimized_stacktrace_line_and_column_test.dart:11:18"), "B");
}
// Optimized.
@@ -30,8 +31,9 @@ test1() {
Expect.fail("Unreachable");
} catch (e, stacktrace) {
String s = stacktrace.toString();
- Expect.isFalse(s.contains("-1:-1"));
- Expect.isTrue(s.contains("11:18"));
+ print(s);
+ Expect.isFalse(s.contains("-1:-1"), "C");
+ Expect.isTrue(s.contains("optimized_stacktrace_line_and_column_test.dart:11:18"), "D");
}
siva 2017/02/11 03:19:00 Does it make sense to extend your markers 'A,B,C e
rmacnak 2017/02/13 18:25:34 Sure, it makes is possible to find which expect is
}

Powered by Google App Engine
This is Rietveld 408576698