Chromium Code Reviews| Index: runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart |
| diff --git a/runtime/tests/vm/dart/optimized_stacktrace_test.dart b/runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart |
| similarity index 84% |
| copy from runtime/tests/vm/dart/optimized_stacktrace_test.dart |
| copy to runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart |
| index d002a2e28b0c32c11d9830998c9206ebb6e96297..bfa7c4443b0b39f4c9ca2246a05493486bbdf553 100644 |
| --- a/runtime/tests/vm/dart/optimized_stacktrace_test.dart |
| +++ b/runtime/tests/vm/dart/optimized_stacktrace_line_and_column_test.dart |
| @@ -19,8 +19,9 @@ test1() { |
| Expect.fail("Unreachable"); |
| } catch (e, stacktrace) { |
| String s = stacktrace.toString(); |
| - Expect.isFalse(s.contains("-1:-1")); |
| - Expect.isTrue(s.contains("11:18")); |
| + print(s); |
| + Expect.isFalse(s.contains("-1:-1"), "A"); |
| + Expect.isTrue(s.contains("optimized_stacktrace_line_and_column_test.dart:11:18"), "B"); |
| } |
| // Optimized. |
| @@ -30,8 +31,9 @@ test1() { |
| Expect.fail("Unreachable"); |
| } catch (e, stacktrace) { |
| String s = stacktrace.toString(); |
| - Expect.isFalse(s.contains("-1:-1")); |
| - Expect.isTrue(s.contains("11:18")); |
| + print(s); |
| + Expect.isFalse(s.contains("-1:-1"), "C"); |
| + Expect.isTrue(s.contains("optimized_stacktrace_line_and_column_test.dart:11:18"), "D"); |
| } |
|
siva
2017/02/11 03:19:00
Does it make sense to extend your markers 'A,B,C e
rmacnak
2017/02/13 18:25:34
Sure, it makes is possible to find which expect is
|
| } |