Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 268713013: Move chrome.usb to //extensions (Closed)

Created:
6 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 7 months ago
Reviewers:
rpaquay
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move chrome.usb to //extensions This moves the chrome.usb API implementation into the core set of extensions APIs. BUG=369391 R=rpaquay TBR=yoz for extensions TBR=sky for +chrome/browser/ui in test DEPS Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268231

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+297 lines, -2377 lines) Patch
D chrome/browser/extensions/api/usb/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/extensions/api/usb/OWNERS View 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/extensions/api/usb/usb_api.h View 1 1 chunk +0 lines, -314 lines 0 comments Download
D chrome/browser/extensions/api/usb/usb_api.cc View 1 1 chunk +0 lines, -1164 lines 0 comments Download
D chrome/browser/extensions/api/usb/usb_apitest.cc View 1 1 chunk +0 lines, -251 lines 0 comments Download
D chrome/browser/extensions/api/usb/usb_device_resource.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/extensions/api/usb/usb_device_resource.cc View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/extensions/api/usb/usb_manual_apitest.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/usb.idl View 1 chunk +0 lines, -307 lines 0 comments Download
M extensions/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
A + extensions/browser/api/usb/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/browser/api/usb/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/browser/api/usb/usb_api.h View 1 17 chunks +31 lines, -28 lines 0 comments Download
A + extensions/browser/api/usb/usb_api.cc View 1 48 chunks +165 lines, -121 lines 0 comments Download
A + extensions/browser/api/usb/usb_apitest.cc View 1 5 chunks +47 lines, -23 lines 0 comments Download
A + extensions/browser/api/usb/usb_device_resource.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + extensions/browser/api/usb/usb_device_resource.cc View 3 chunks +4 lines, -3 lines 0 comments Download
A + extensions/browser/api/usb/usb_manual_apitest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M extensions/common/api/_api_features.json View 1 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 chunk +29 lines, -1 line 0 comments Download
M extensions/common/api/api.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + extensions/common/api/usb.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M extensions/extensions.gyp View 3 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ken Rockot(use gerrit already)
Another one for you :) This is just a mechanical move of the USB API ...
6 years, 7 months ago (2014-05-02 04:52:49 UTC) #1
rpaquay
lgtm https://codereview.chromium.org/268713013/diff/1/extensions/browser/api/usb/usb_api.cc File extensions/browser/api/usb/usb_api.cc (right): https://codereview.chromium.org/268713013/diff/1/extensions/browser/api/usb/usb_api.cc#newcode106 extensions/browser/api/usb/usb_api.cc:106: "Packet length must be a " Shouldn't these ...
6 years, 7 months ago (2014-05-05 15:58:56 UTC) #2
Ken Rockot(use gerrit already)
https://codereview.chromium.org/268713013/diff/1/extensions/browser/api/usb/usb_api.cc File extensions/browser/api/usb/usb_api.cc (right): https://codereview.chromium.org/268713013/diff/1/extensions/browser/api/usb/usb_api.cc#newcode106 extensions/browser/api/usb/usb_api.cc:106: "Packet length must be a " On 2014/05/05 15:58:57, ...
6 years, 7 months ago (2014-05-05 16:24:33 UTC) #3
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 7 months ago (2014-05-05 16:26:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/268713013/20001
6 years, 7 months ago (2014-05-05 16:26:56 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 18:40:15 UTC) #6
Message was sent while issue was closed. 
Change committed as 268231

Powered by Google App Engine
This is Rietveld 408576698