Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 268713006: Convert media.gyp on Linux. (Closed)

Created:
6 years, 7 months ago by awong
Modified:
6 years, 5 months ago
Reviewers:
brettw, DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Converts most logic in media.gyp to BUILD.gn files. Most everything but android and cdm code has been converted. Next step is to break these up into smaller BUILD.gn files per subdirectory. All hail GN. orz BUG=none R=brettw@chromium.org, dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282448

Patch Set 1 #

Total comments: 2

Patch Set 2 : refreshed after all the gn & dependency fixes #

Patch Set 3 : 世界革命をするために #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1362 lines, -0 lines) Patch
A media/BUILD.gn View 1 2 1 chunk +1362 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
awong
@brettw: GN style sanity check...and also to show the insanity coming down the pipe. @dalecurtis: ...
6 years, 7 months ago (2014-05-01 21:58:26 UTC) #1
brettw
high level lgtm https://codereview.chromium.org/268713006/diff/1/media/BUILD.gn File media/BUILD.gn (right): https://codereview.chromium.org/268713006/diff/1/media/BUILD.gn#newcode31 media/BUILD.gn:31: # TODO(ajwong): These variables need set ...
6 years, 7 months ago (2014-05-05 19:38:02 UTC) #2
awong
https://codereview.chromium.org/268713006/diff/1/media/BUILD.gn File media/BUILD.gn (right): https://codereview.chromium.org/268713006/diff/1/media/BUILD.gn#newcode31 media/BUILD.gn:31: # TODO(ajwong): These variables need set appropriately. On 2014/05/05 ...
6 years, 7 months ago (2014-05-05 20:47:47 UTC) #3
DaleCurtis
rslgtm
6 years, 7 months ago (2014-05-05 21:46:29 UTC) #4
awong
On 2014/05/05 21:46:29, DaleCurtis wrote: > rslgtm rs?
6 years, 7 months ago (2014-05-05 21:47:13 UTC) #5
DaleCurtis
RubberStamp, though I did look through this, I just don't understand most of it :)
6 years, 7 months ago (2014-05-05 21:50:40 UTC) #6
awong
On 2014/05/05 21:50:40, DaleCurtis_OOO_Jul1-8 wrote: > RubberStamp, though I did look through this, I just ...
6 years, 5 months ago (2014-07-08 02:49:38 UTC) #7
awong
On 2014/07/08 02:49:38, awong wrote: > On 2014/05/05 21:50:40, DaleCurtis_OOO_Jul1-8 wrote: > > RubberStamp, though ...
6 years, 5 months ago (2014-07-10 22:53:33 UTC) #8
awong
6 years, 5 months ago (2014-07-10 22:54:46 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 manually as r282448 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698