Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: src/heap/heap.h

Issue 2687113002: [heap] no longer perform GC to make heap iterable. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/liveedit.cc ('k') | src/heap/heap.cc » ('j') | src/heap/heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index d8986f3557394fe8cd4ef69867641f5b167c8710..c32e2084a85bbe49a8e61641fb21a73ecfd339c1 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -766,9 +766,6 @@ class Heap {
// Converts the given boolean condition to JavaScript boolean value.
inline Oddball* ToBoolean(bool condition);
- // Check whether the heap is currently iterable.
- bool IsHeapIterable();
-
// Notify the heap that a context has been disposed.
int NotifyContextDisposed(bool dependant_context);
@@ -2548,17 +2545,8 @@ class HeapIterator BASE_EMBEDDED {
HeapObject* next();
private:
- struct MakeHeapIterableHelper {
- explicit MakeHeapIterableHelper(Heap* heap) { heap->MakeHeapIterable(); }
- };
-
HeapObject* NextObject();
- // The following two fields need to be declared in this order. Initialization
- // order guarantees that we first make the heap iterable (which may involve
- // allocations) and only then lock it down by not allowing further
- // allocations.
- MakeHeapIterableHelper make_heap_iterable_helper_;
DisallowHeapAllocation no_heap_allocation_;
Heap* heap_;
« no previous file with comments | « src/debug/liveedit.cc ('k') | src/heap/heap.cc » ('j') | src/heap/heap.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698