Issue 2687043003: GetThreatSeverity should handle the case of CheckResourceUrl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2687043003: GetThreatSeverity should handle the case of CheckResourceUrl. (Closed)

Created:
3 years, 10 months ago by scottmg

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

More Reviews

Description

GetThreatSeverity should handle the case of CheckResourceUrl. Added the case statement and a unit test that forces a full hash match which causes this method to get executed. BUG=689672 Review-Url: https://codereview.chromium.org/2680163002 Cr-Commit-Position: refs/heads/master@{#448885} (cherry picked from commit 4e2788493f4bef375b52e78e5a9ee38f2d92b191)

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -15 lines)			Patch
	M	components/safe_browsing_db/v4_local_database_manager.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	components/safe_browsing_db/v4_local_database_manager_unittest.cc	View		9 chunks	+86 lines, -15 lines	0 comments	Download