Issue 268703005: Fix TabManager for Chrome Shell so it supports swapping WebContents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268703005: Fix TabManager for Chrome Shell so it supports swapping WebContents. (Closed)

Created:
6 years, 7 months ago by nyquist

Modified:
6 years, 7 months ago

Reviewers:
David Trainor- moved to gerrit

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix TabManager for Chrome Shell so it supports swapping WebContents. This CL adds an observer of the current Tab in the Chrome Shell TabManager so it knows when the underlying content changes. BUG=361939 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268020

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -4 lines)			Patch
	M	chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java	View		3 chunks	+21 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/268703005/1

6 years, 7 months ago (2014-05-02 23:37:51 UTC) #4

Message was sent while issue was closed.

Change committed as 268020

Expand Messages | Collapse Messages