Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: runtime/bin/gen_snapshot.cc

Issue 2687023002: gen_snapshot: When copying an error across isolates, remember to turn it back into an error. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/gen_snapshot.cc
diff --git a/runtime/bin/gen_snapshot.cc b/runtime/bin/gen_snapshot.cc
index beb89f9e7c2e462a3293e7c2a3f2988b09c9ad6c..732493d5fe11dd42cf3c9cdf7dad25252f531a6f 100644
--- a/runtime/bin/gen_snapshot.cc
+++ b/runtime/bin/gen_snapshot.cc
@@ -448,7 +448,7 @@ static Dart_Handle LoadUrlContents(const char* uri_string) {
result = Dart_NewStringFromUTF8(payload, payload_length);
free(payload);
} else {
- result = DartUtils::NewString(result_string);
+ result = Dart_NewApiError(result_string);
free(result_string);
}
return result;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698