Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Side by Side Diff: src/inspector/debugger-script.js

Issue 2687013003: Revert of [debugger] expose side-effect free evaluate to inspector. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/flag-definitions.h ('k') | src/inspector/debugger_script_externs.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
438 { 438 {
439 var mirror = ensureFuncMirror(); 439 var mirror = ensureFuncMirror();
440 var context = mirror.context(); 440 var context = mirror.context();
441 if (context && context.data()) 441 if (context && context.data())
442 return Number(context.data()); 442 return Number(context.data());
443 return 0; 443 return 0;
444 } 444 }
445 445
446 /** 446 /**
447 * @param {string} expression 447 * @param {string} expression
448 * @param {boolean} throwOnSideEffect
449 * @return {*} 448 * @return {*}
450 */ 449 */
451 function evaluate(expression, throwOnSideEffect) 450 function evaluate(expression)
452 { 451 {
453 return frameMirror.evaluate(expression, throwOnSideEffect).value(); 452 return frameMirror.evaluate(expression).value();
454 } 453 }
455 454
456 /** @return {undefined} */ 455 /** @return {undefined} */
457 function restart() 456 function restart()
458 { 457 {
459 return frameMirror.restart(); 458 return frameMirror.restart();
460 } 459 }
461 460
462 /** 461 /**
463 * @param {number} scopeNumber 462 * @param {number} scopeNumber
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
523 case ScopeType.Global: 522 case ScopeType.Global:
524 case ScopeType.With: 523 case ScopeType.With:
525 result = scopeObject; 524 result = scopeObject;
526 break; 525 break;
527 } 526 }
528 return result; 527 return result;
529 } 528 }
530 529
531 return DebuggerScript; 530 return DebuggerScript;
532 })(); 531 })();
OLDNEW
« no previous file with comments | « src/flag-definitions.h ('k') | src/inspector/debugger_script_externs.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698