chrome/browser/ui/browser_navigator.cc - Issue 2686943002: New WebContents created via ctrl-click should be in a new process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_navigator.cc

Issue 2686943002: New WebContents created via ctrl-click should be in a new process. (Closed)

Patch Set: Verify |window.opener| in the new ExtensionApiTest.WindowsCreateVsSiteInstance test. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_navigator.cc

diff --git a/chrome/browser/ui/browser_navigator.cc b/chrome/browser/ui/browser_navigator.cc

index 1a7e8063626468d6f4ecb99c13cc336d3efca219..48f5d33b4224c2bdfa3183b3269f24086a63c2ff 100644

--- a/chrome/browser/ui/browser_navigator.cc

+++ b/chrome/browser/ui/browser_navigator.cc

@@ -356,7 +356,7 @@ content::WebContents* CreateTargetContents(const chrome::NavigateParams& params,

const GURL& url) {

WebContents::CreateParams create_params(

params.browser->profile(),

- params.source_site_instance

+ params.source_site_instance && !params.use_new_renderer_for_new_contents

? params.source_site_instance

: tab_util::GetSiteInstanceForNewTab(params.browser->profile(), url));

create_params.main_frame_name = params.frame_name;