Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: chrome/browser/ui/browser_navigator_params.h

Issue 2686943002: New WebContents created via ctrl-click should be in a new process. (Closed)
Patch Set: s/use_new_renderer.../force_new_renderer.../ + comment changes. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_ 5 #ifndef CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_
6 #define CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_ 6 #define CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 // CURRENT_TAB " " " NEW_FOREGROUND_TAB 125 // CURRENT_TAB " " " NEW_FOREGROUND_TAB
126 // OFF_THE_RECORD target browser profile is incog. NEW_FOREGROUND_TAB 126 // OFF_THE_RECORD target browser profile is incog. NEW_FOREGROUND_TAB
127 // 127 //
128 // If disposition is NEW_BACKGROUND_TAB, TabStripModel::ADD_ACTIVE is 128 // If disposition is NEW_BACKGROUND_TAB, TabStripModel::ADD_ACTIVE is
129 // removed from |tabstrip_add_types| automatically. 129 // removed from |tabstrip_add_types| automatically.
130 // If disposition is one of NEW_WINDOW, NEW_POPUP, NEW_FOREGROUND_TAB or 130 // If disposition is one of NEW_WINDOW, NEW_POPUP, NEW_FOREGROUND_TAB or
131 // SINGLETON_TAB, then TabStripModel::ADD_ACTIVE is automatically added to 131 // SINGLETON_TAB, then TabStripModel::ADD_ACTIVE is automatically added to
132 // |tabstrip_add_types|. 132 // |tabstrip_add_types|.
133 WindowOpenDisposition disposition; 133 WindowOpenDisposition disposition;
134 134
135 // Controls creation of new web contents (in case |disposition| asks for a new
136 // tab or window). If |force_new_renderer_for_new_contents| is true, then we
137 // try to put the new contents in a new renderer, even if they are same-site
138 // as |source_site_instance| (this is subject to renderer process limits).
139 bool force_new_renderer_for_new_contents;
sky 2017/04/20 21:00:57 I find the use of renderer mildly confusing here.
Łukasz Anforowicz 2017/04/20 21:56:05 Done.
140
135 // Sets browser->is_trusted_source. Default is false. 141 // Sets browser->is_trusted_source. Default is false.
136 bool trusted_source; 142 bool trusted_source;
137 143
138 // The transition type of the navigation. Default is 144 // The transition type of the navigation. Default is
139 // ui::PAGE_TRANSITION_LINK when target_contents is specified in the 145 // ui::PAGE_TRANSITION_LINK when target_contents is specified in the
140 // constructor. 146 // constructor.
141 ui::PageTransition transition; 147 ui::PageTransition transition;
142 148
143 // Whether this navigation was initiated by the renderer process. Default is 149 // Whether this navigation was initiated by the renderer process. Default is
144 // false. 150 // false.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 NavigateParams(); 253 NavigateParams();
248 }; 254 };
249 255
250 // Copies fields from |params| struct to |nav_params| struct. 256 // Copies fields from |params| struct to |nav_params| struct.
251 void FillNavigateParamsFromOpenURLParams(chrome::NavigateParams* nav_params, 257 void FillNavigateParamsFromOpenURLParams(chrome::NavigateParams* nav_params,
252 const content::OpenURLParams& params); 258 const content::OpenURLParams& params);
253 259
254 } // namespace chrome 260 } // namespace chrome
255 261
256 #endif // CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_ 262 #endif // CHROME_BROWSER_UI_BROWSER_NAVIGATOR_PARAMS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698