Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Side by Side Diff: content/public/browser/page_navigator.h

Issue 2686943002: New WebContents created via ctrl-click should be in a new process. (Closed)
Patch Set: No need to send the new boolean flag over IPC. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // PageNavigator defines an interface that can be used to express the user's 5 // PageNavigator defines an interface that can be used to express the user's
6 // intention to navigate to a particular URL. The implementing class should 6 // intention to navigate to a particular URL. The implementing class should
7 // perform the navigation. 7 // perform the navigation.
8 8
9 #ifndef CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_ 9 #ifndef CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_
10 #define CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_ 10 #define CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 75
76 // Routing id of the source RenderFrameHost. 76 // Routing id of the source RenderFrameHost.
77 int source_render_frame_id = MSG_ROUTING_NONE; 77 int source_render_frame_id = MSG_ROUTING_NONE;
78 78
79 // Process id of the source RenderFrameHost. 79 // Process id of the source RenderFrameHost.
80 int source_render_process_id = ChildProcessHost::kInvalidUniqueID; 80 int source_render_process_id = ChildProcessHost::kInvalidUniqueID;
81 81
82 // The disposition requested by the navigation source. 82 // The disposition requested by the navigation source.
83 WindowOpenDisposition disposition; 83 WindowOpenDisposition disposition;
84 84
85 // Controls whether newly created web contents (in case if |disposition| asks
Charlie Reis 2017/04/19 20:11:11 nit: Drop "if"
Łukasz Anforowicz 2017/04/20 01:11:29 Done.
86 // for a new tab or window) should attempt to reuse the renderer process of
87 // |source_site_instance|. For example - new contents created after
88 // ctrl-clicking a link should use always a new renderer, but
89 // chrome.windows.create extensions API should try to keep the new contents in
90 // the same extension process (if same-site).
91 bool use_new_renderer_for_new_contents;
92
85 // The transition type of navigation. 93 // The transition type of navigation.
86 ui::PageTransition transition; 94 ui::PageTransition transition;
87 95
88 // Whether this navigation is initiated by the renderer process. 96 // Whether this navigation is initiated by the renderer process.
89 bool is_renderer_initiated; 97 bool is_renderer_initiated;
90 98
91 // Indicates whether this navigation should replace the current 99 // Indicates whether this navigation should replace the current
92 // navigation entry. 100 // navigation entry.
93 bool should_replace_current_entry; 101 bool should_replace_current_entry;
94 102
(...skipping 15 matching lines...) Expand all
110 // Opens a URL with the given disposition. The transition specifies how this 118 // Opens a URL with the given disposition. The transition specifies how this
111 // navigation should be recorded in the history system (for example, typed). 119 // navigation should be recorded in the history system (for example, typed).
112 // Returns the WebContents the URL is opened in, or nullptr if the URL wasn't 120 // Returns the WebContents the URL is opened in, or nullptr if the URL wasn't
113 // opened immediately. 121 // opened immediately.
114 virtual WebContents* OpenURL(const OpenURLParams& params) = 0; 122 virtual WebContents* OpenURL(const OpenURLParams& params) = 0;
115 }; 123 };
116 124
117 } // namespace content 125 } // namespace content
118 126
119 #endif // CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_ 127 #endif // CONTENT_PUBLIC_BROWSER_PAGE_NAVIGATOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698