Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2686843003: Don't re-read files when compute their analysis results. (Closed)

Created:
3 years, 10 months ago by scheglov
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't re-read files when compute their analysis results. We don't really need this. The client must notify us that the file was changed. Then we will re-read it. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/832f10e5898bc64f840a65682a75fe22b251633c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
3 years, 10 months ago (2017-02-08 21:42:16 UTC) #1
Brian Wilkerson
lgtm
3 years, 10 months ago (2017-02-08 22:08:57 UTC) #2
Paul Berry
lgtm
3 years, 10 months ago (2017-02-08 22:22:13 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as 832f10e5898bc64f840a65682a75fe22b251633c (presubmit successful).
3 years, 10 months ago (2017-02-09 03:21:21 UTC) #5
Paul Berry
3 years, 10 months ago (2017-02-09 12:51:01 UTC) #6
Message was sent while issue was closed.
On 2017/02/09 03:21:21, scheglov wrote:
> Committed patchset #1 (id:1) manually as
> 832f10e5898bc64f840a65682a75fe22b251633c (presubmit successful).

This change produced failures in FixProcessorTest_Driver (see
https://build.chromium.org/p/client.dart/builders/analyzer-linux-release-be/b...)

Repro with: dart pkg/analysis_server/test/services/correction/fix_test.dart

Would you mind having a look?

Powered by Google App Engine
This is Rietveld 408576698