Fix the toggle caps lock accelerator not always working.

ash/common/accelerators/accelerator_table.cc

Index: ash/common/accelerators/accelerator_table.cc
diff --git a/ash/common/accelerators/accelerator_table.cc b/ash/common/accelerators/accelerator_table.cc
index 602a3249dc9a8d94dd47d466516c3908b3a67f01..6bc6fa850e426b8bcda5e61e27d3a8f48f0615bd 100644
--- a/ash/common/accelerators/accelerator_table.cc
+++ b/ash/common/accelerators/accelerator_table.cc
@@ -85,6 +85,7 @@ const AcceleratorData kAcceleratorData[] = {
     {false, ui::VKEY_SHIFT, ui::EF_NONE, DISABLE_CAPS_LOCK},
     {false, ui::VKEY_RSHIFT, ui::EF_NONE, DISABLE_CAPS_LOCK},
     {false, ui::VKEY_LWIN, ui::EF_ALT_DOWN, TOGGLE_CAPS_LOCK},
+    {false, ui::VKEY_MENU, ui::EF_COMMAND_DOWN, TOGGLE_CAPS_LOCK},

[James Cook, 2017/02/08 22:39:08]

Could you add a comment here? This is super-confusing because EF_COMMAND_DOWN is
search but VKEY_MENU is sort-of Alt. Or add a comment in
ui/events/keycodes/keyboard_codes_posix.h or both.

[afakhry, 2017/02/09 00:28:30]

Yes, it is confusing. VKEY_MENU is Alt as a key_code, but when used as a
modifier it becomes EF_ALT_DOWN. Similarly for Search, as a key_code it's
VKEY_LWIN, and as a modifier it's EF_COMMAND_DOWN.


Please take a look at the comments I added.

[James Cook, 2017/02/09 01:22:21]

Nice. Well written.

     {true, ui::VKEY_VOLUME_MUTE, ui::EF_NONE, VOLUME_MUTE},
     {true, ui::VKEY_VOLUME_DOWN, ui::EF_NONE, VOLUME_DOWN},
     {true, ui::VKEY_VOLUME_UP, ui::EF_NONE, VOLUME_UP},