Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2686833004: Skip input-implicit-limit test. (Closed)

Created:
3 years, 10 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 10 months ago
Reviewers:
Bill Hesse, Alan Knight
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Skip input-implicit-limit test. This test is verifying a DOM-related bug in webkit. It started failing on the latest chrome because it has been fixed. I honestly don't know if there is value in us running this test altogether, since there is nothing Dart specific about it. R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/def986fee7fe9c2aa680af5cf9b2e14c1a9c7056

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M tests/co19/co19-dart2js.status View 5 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-02-08 16:49:53 UTC) #2
Bill Hesse
lgtm
3 years, 10 months ago (2017-02-08 18:16:19 UTC) #3
Siggi Cherem (dart-lang)
3 years, 10 months ago (2017-02-09 00:03:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
def986fee7fe9c2aa680af5cf9b2e14c1a9c7056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698