cc/ipc/copy_output_result.mojom - Issue 2686833003: CopyOutputResult must have a working release callback when received over mojo

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/ipc/copy_output_result.mojom

Issue 2686833003: CopyOutputResult must have a working release callback when received over mojo (Closed)

Patch Set: c Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module cc.mojom;	5 module cc.mojom;

6	6

7 import "cc/ipc/texture_mailbox.mojom";	7 import "cc/ipc/texture_mailbox.mojom";

	8 import "cc/ipc/texture_mailbox_releaser.mojom";

8 import "skia/public/interfaces/bitmap.mojom";	9 import "skia/public/interfaces/bitmap.mojom";

9 import "ui/gfx/geometry/mojo/geometry.mojom";	10 import "ui/gfx/geometry/mojo/geometry.mojom";

10	11

11 // See cc/output/copy_output_result.h.	12 // See cc/output/copy_output_result.h.

12 struct CopyOutputResult {	13 struct CopyOutputResult {

13 gfx.mojom.Size size;	14 gfx.mojom.Size size;
	danakj 2017/02/14 17:49:10 This should be optional, it's only used for textur This should be optional, it's only used for texture results: https://cs.chromium.org/chromium/src/cc/output/copy_output_result.h?rcl=c8e27... Saman Sami 2017/02/14 22:17:04 Acknowledged. Show quoted text On 2017/02/14 17:49:10, danakj wrote: > This should be optional, it's only used for texture results: > https://cs.chromium.org/chromium/src/cc/output/copy_output_result.h?rcl=c8e27... Acknowledged. danakj 2017/02/14 23:49:34 Looks like this shouldn't be ? cuz ? refers to a m Show quoted text On 2017/02/14 22:17:04, Saman Sami wrote: > On 2017/02/14 17:49:10, danakj wrote: > > This should be optional, it's only used for texture results: > > > https://cs.chromium.org/chromium/src/cc/output/copy_output_result.h?rcl=c8e27... > > Acknowledged. Looks like this shouldn't be ? cuz ? refers to a magic null value which Size doesn't have, not to the field being optional.
14 skia.mojom.Bitmap? bitmap;	15 skia.mojom.Bitmap? bitmap;

15 cc.mojom.TextureMailbox texture_mailbox;	16 TextureMailbox? texture_mailbox;

	17 TextureMailboxReleaser? releaser;

16 };	18 };

OLD	NEW

« no previous file with comments | « cc/ipc/BUILD.gn ('k') | cc/ipc/copy_output_result_struct_traits.h » ('j') | cc/ipc/copy_output_result_struct_traits.cc » ('J')