runtime/vm/disassembler.cc - Issue 2686813006: Reapply "Use CodeSourceMap for stack traces (still JIT only)."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/disassembler.cc

Issue 2686813006: Reapply "Use CodeSourceMap for stack traces (still JIT only)." (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/disassembler.cc

diff --git a/runtime/vm/disassembler.cc b/runtime/vm/disassembler.cc

index 142f42ee8edd555b65df6c18d70d43625231f77a..c51f6e4be3b337d027f727a37167e8b2dda46fc6 100644

--- a/runtime/vm/disassembler.cc

+++ b/runtime/vm/disassembler.cc

@@ -129,7 +129,8 @@ void Disassembler::Disassemble(uword start,

char str[4000];

BufferFormatter f(str, sizeof(str));

// Comment emitted, emit inlining information.

- code.GetInlinedFunctionsAt(offset, &inlined_functions, &token_positions);

+ code.GetInlinedFunctionsAtInstruction(offset, &inlined_functions,

+ &token_positions);

// Skip top scope function printing (last entry in 'inlined_functions').

bool first = true;

for (intptr_t i = 1; i < inlined_functions.length(); i++) {

« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/exceptions.cc » ('j') | no next file with comments »