Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: chrome/browser/devtools/device/devtools_device_discovery.h

Issue 2686803002: Make nested classes of DevToolsDeviceDiscovery RefCountedThreadSafe (Closed)
Patch Set: s/RefCounted/RefCountedThreadSafe/ Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/devtools_device_discovery.h
diff --git a/chrome/browser/devtools/device/devtools_device_discovery.h b/chrome/browser/devtools/device/devtools_device_discovery.h
index e89e84117c5c1e2c4b7a0f4efd88e74f775eac6d..7c35548f60ef8af11b0cb6956583d1eac97851ef 100644
--- a/chrome/browser/devtools/device/devtools_device_discovery.h
+++ b/chrome/browser/devtools/device/devtools_device_discovery.h
@@ -18,7 +18,7 @@
class DevToolsDeviceDiscovery {
public:
- class RemotePage : public base::RefCounted<RemotePage> {
+ class RemotePage : public base::RefCountedThreadSafe<RemotePage> {
public:
scoped_refptr<AndroidDeviceManager::Device> device() { return device_; }
const std::string& socket() { return browser_id_; }
@@ -26,7 +26,7 @@ class DevToolsDeviceDiscovery {
scoped_refptr<content::DevToolsAgentHost> CreateTarget();
private:
- friend class base::RefCounted<RemotePage>;
+ friend class base::RefCountedThreadSafe<RemotePage>;
friend class DevToolsDeviceDiscovery;
RemotePage(scoped_refptr<AndroidDeviceManager::Device> device,
@@ -45,7 +45,7 @@ class DevToolsDeviceDiscovery {
using RemotePages = std::vector<scoped_refptr<RemotePage>>;
- class RemoteBrowser : public base::RefCounted<RemoteBrowser> {
+ class RemoteBrowser : public base::RefCountedThreadSafe<RemoteBrowser> {
public:
const std::string& serial() { return serial_; }
const std::string& socket() { return browser_id_; }
@@ -61,7 +61,7 @@ class DevToolsDeviceDiscovery {
ParsedVersion GetParsedVersion();
private:
- friend class base::RefCounted<RemoteBrowser>;
+ friend class base::RefCountedThreadSafe<RemoteBrowser>;
friend class DevToolsDeviceDiscovery;
RemoteBrowser(const std::string& serial,
@@ -82,7 +82,7 @@ class DevToolsDeviceDiscovery {
using RemoteBrowsers = std::vector<scoped_refptr<RemoteBrowser>>;
- class RemoteDevice : public base::RefCounted<RemoteDevice> {
+ class RemoteDevice : public base::RefCountedThreadSafe<RemoteDevice> {
public:
std::string serial() { return serial_; }
std::string model() { return model_; }
@@ -91,7 +91,7 @@ class DevToolsDeviceDiscovery {
gfx::Size screen_size() { return screen_size_; }
private:
- friend class base::RefCounted<RemoteDevice>;
+ friend class base::RefCountedThreadSafe<RemoteDevice>;
friend class DevToolsDeviceDiscovery;
RemoteDevice(const std::string& serial,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698