Issue 26868004: Set default resource constraints on V8 before the the default isolate is initialized

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26868004: Set default resource constraints on V8 before the the default isolate is initialized (Closed)

Created:
7 years, 2 months ago by rmcilroy

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium

CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Set default resource constraints on V8 before the the default isolate is initialized. The previous code was calling SetResourceConstraints too late, which causes an ASSERT to fire in V8 when compiled in debug mode. Unfortunately the chromium and blink debug builds don't compile V8 in debug mode, so this was not discovered until manually changing the V8 gyp flags. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161052

Patch Set 1 #

Patch Set 2 : Fix workers too. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
M	Source/bindings/v8/V8Initializer.cpp	View	1	3 chunks	+0 lines, -3 lines	0 comments	Download
M	Source/bindings/v8/WorkerScriptController.cpp	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	Source/web/WebKit.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/26868004/3001

7 years, 2 months ago (2013-10-18 16:11:43 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/26868004/3001

7 years, 1 month ago (2013-10-31 11:19:47 UTC) #4

Message was sent while issue was closed.

Change committed as 161052

Expand Messages | Collapse Messages