Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: chrome/common/safe_browsing/csd.proto

Issue 268673007: Extracting page shingle hashes for similarity detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address 1st round comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Client side phishing and malware detection request and response 5 // Client side phishing and malware detection request and response
6 // protocol buffers. Those protocol messages should be kept in sync 6 // protocol buffers. Those protocol messages should be kept in sync
7 // with the server implementation. 7 // with the server implementation.
8 // 8 //
9 // If you want to change this protocol definition or you have questions 9 // If you want to change this protocol definition or you have questions
10 // regarding its format please contact chrome-anti-phishing@googlegroups.com. 10 // regarding its format please contact chrome-anti-phishing@googlegroups.com.
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 // List of features that are extracted in the client but are not used in the 61 // List of features that are extracted in the client but are not used in the
62 // machine learning model. 62 // machine learning model.
63 repeated Feature non_model_feature_map = 8; 63 repeated Feature non_model_feature_map = 8;
64 64
65 // The referrer URL. This field might not be set, for example, in the case 65 // The referrer URL. This field might not be set, for example, in the case
66 // where the referrer uses HTTPs. 66 // where the referrer uses HTTPs.
67 // OBSOLETE: Use feature 'Referrer=<referrer>' instead. 67 // OBSOLETE: Use feature 'Referrer=<referrer>' instead.
68 optional string OBSOLETE_referrer_url = 9; 68 optional string OBSOLETE_referrer_url = 9;
69 69
70 // Field 11 is only used on the server. 70 // Field 11 is only used on the server.
71
72 // List of shingle hashes we extracted.
73 repeated uint32 shingle_hashes = 12;
noelutz 2014/05/06 21:40:18 don't forget to mark these as packed as well. Oth
zysxqn 2014/05/07 19:29:19 Done.
71 } 74 }
72 75
73 message ClientPhishingResponse { 76 message ClientPhishingResponse {
74 required bool phishy = 1; 77 required bool phishy = 1;
75 78
76 // A list of SafeBrowsing host-suffix / path-prefix expressions that 79 // A list of SafeBrowsing host-suffix / path-prefix expressions that
77 // are whitelisted. The client must match the current top-level URL 80 // are whitelisted. The client must match the current top-level URL
78 // against these whitelisted expressions and only apply a positive 81 // against these whitelisted expressions and only apply a positive
79 // phishing verdict above if the URL does not match any expression 82 // phishing verdict above if the URL does not match any expression
80 // on this whitelist. The client must not cache these whitelisted 83 // on this whitelist. The client must not cache these whitelisted
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 // The upload was unsuccessful and the response is incomplete. 327 // The upload was unsuccessful and the response is incomplete.
325 UPLOAD_FAILURE = 1; 328 UPLOAD_FAILURE = 1;
326 } 329 }
327 330
328 // Holds the upload status 331 // Holds the upload status
329 optional UploadStatus status = 1; 332 optional UploadStatus status = 1;
330 333
331 // Holds the permalink where the results of scanning the binary are available 334 // Holds the permalink where the results of scanning the binary are available
332 optional string permalink = 2; 335 optional string permalink = 2;
333 } 336 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698