Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

Issue 2686713003: DevTools: Disable timeline network pane resizer when network group is collapsed. (Closed)
Patch Set: make it work for real Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
index bf75d60a61826c5f7ac262e5be705beb2a657d31..67b6a7eb948ef9d13250c29434f20675312037fb 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
@@ -131,15 +131,15 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {
this._networkView.alwaysShowVerticalScroll();
networkViewGroupExpansionSetting.addChangeListener(this.resizeToPreferredHeights.bind(this));
- const networkPane = new UI.VBox();
- networkPane.setMinimumSize(23, 23);
- this._networkView.show(networkPane.element);
- this._splitResizer = networkPane.element.createChild('div', 'timeline-flamechart-resizer');
- this._splitWidget.hideDefaultResizer();
+ this._networkPane = new UI.VBox();
+ this._networkPane.setMinimumSize(23, 23);
+ this._networkView.show(this._networkPane.element);
+ this._splitResizer = this._networkPane.element.createChild('div', 'timeline-flamechart-resizer');
+ this._splitWidget.hideDefaultResizer(true);
this._splitWidget.installResizer(this._splitResizer);
this._splitWidget.setMainWidget(this._mainView);
- this._splitWidget.setSidebarWidget(networkPane);
+ this._splitWidget.setSidebarWidget(this._networkPane);
if (Runtime.experiments.isEnabled('timelineMultipleMainViews')) {
// Create top level properties splitter.
@@ -321,9 +321,11 @@ Timeline.TimelineFlameChartView = class extends UI.VBox {
}
resizeToPreferredHeights() {
+ this._networkPane.element.classList.toggle(
+ 'timeline-network-resizer-disabled', !this._networkDataProvider.isExpanded());
this._splitWidget.setSidebarSize(
this._networkDataProvider.preferredHeight() + this._splitResizer.clientHeight + PerfUI.FlameChart.HeaderHeight +
- 3);
+ 2);
}
};
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698