ABANDONED CL: WaitForChildFrameSurfaceReady to avoid flaky test hangs.

content/test/content_browser_test_utils_internal.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/test/content_browser_test_utils_internal.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <map>
 #include <set>
 #include <vector>
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/test/test_timeouts.h"
 #include "base/threading/thread_task_runner_handle.h"
-#include "cc/surfaces/surface.h"
-#include "cc/surfaces/surface_manager.h"
 #include "content/browser/compositor/surface_utils.h"
-#include "content/browser/frame_host/cross_process_frame_connector.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/navigator.h"
 #include "content/browser/frame_host/render_frame_host_delegate.h"
 #include "content/browser/frame_host/render_frame_proxy_host.h"
-#include "content/browser/frame_host/render_widget_host_view_child_frame.h"
 #include "content/browser/renderer_host/delegated_frame_host.h"
-#include "content/browser/renderer_host/render_widget_host_view_base.h"
 #include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/resource_dispatcher_host.h"
 #include "content/public/browser/resource_throttle.h"
 #include "content/public/common/file_chooser_file_info.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/public/test/test_frame_navigation_observer.h"
 #include "content/shell/browser/shell.h"
 #include "content/shell/browser/shell_javascript_dialog_manager.h"
@@ skipping 244 matching lines @@
   // ResourceThrottle
   void WillStartRequest(bool* defer) override { *defer = true; }
 
   const char* GetNameForLogging() const override {
     return "HttpRequestStallThrottle";
   }
 };
 
 }  // namespace
 
-SurfaceHitTestReadyNotifier::SurfaceHitTestReadyNotifier(
-    RenderWidgetHostViewChildFrame* target_view)
-    : target_view_(target_view) {
-  surface_manager_ = GetSurfaceManager();
-}
-
-void SurfaceHitTestReadyNotifier::WaitForSurfaceReady() {
-  root_surface_id_ = target_view_->FrameConnectorForTesting()
-                         ->GetRootRenderWidgetHostViewForTesting()
-                         ->SurfaceIdForTesting();
-  if (ContainsSurfaceId(root_surface_id_))
-    return;
-
-  while (true) {
-    // TODO(kenrb): Need a better way to do this. If
-    // RenderWidgetHostViewBase lifetime observer lands (see
-    // https://codereview.chromium.org/1711103002/), we can add a callback
-    // from OnSwapCompositorFrame and avoid this busy waiting, which is very
-    // frequent in tests in this file.
-    base::RunLoop run_loop;
-    base::ThreadTaskRunnerHandle::Get()->PostDelayedTask(
-        FROM_HERE, run_loop.QuitClosure(), TestTimeouts::tiny_timeout());
-    run_loop.Run();
-    if (ContainsSurfaceId(root_surface_id_))
-      break;
-  }
-}
-
-bool SurfaceHitTestReadyNotifier::ContainsSurfaceId(
-    cc::SurfaceId container_surface_id) {
-  if (!container_surface_id.is_valid())
-    return false;
-  for (cc::SurfaceId id :
-       surface_manager_->GetSurfaceForId(container_surface_id)
-           ->referenced_surfaces()) {
-    if (id == target_view_->SurfaceIdForTesting() || ContainsSurfaceId(id))
-      return true;
-  }
-  return false;
-}
-
 NavigationStallDelegate::NavigationStallDelegate(const GURL& url) : url_(url) {}
 
 void NavigationStallDelegate::RequestBeginning(
     net::URLRequest* request,
     content::ResourceContext* resource_context,
     content::AppCacheService* appcache_service,
     ResourceType resource_type,
     std::vector<std::unique_ptr<content::ResourceThrottle>>* throttles) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
   if (request->url() == url_)
@@ skipping 48 matching lines @@
     NavigationHandle* navigation_handle) {
   if (navigation_handle->HasCommitted() &&
       !navigation_handle->IsErrorPage() &&
       navigation_handle->GetURL() == url_ &&
       navigation_handle->GetFrameTreeNodeId() == frame_tree_node_id_) {
     run_loop_.Quit();
   }
 }
 
 }  // namespace content