Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 268663005: Add use counters for a number of extensions and non-standard APIs (Closed)

Created:
6 years, 7 months ago by philipj_slow
Modified:
6 years, 7 months ago
CC:
blink-reviews, krit, blink-reviews-html_chromium.org, arv+blink, sof, eae+blinkwatch, fs, kouhei+svg_chromium.org, blink-reviews-dom_chromium.org, dglazkov+blink, pdr., f(malita), adamk+blink_chromium.org, gyuyoung.kim_webkit.org, Stephen Chennney, rwlbuis, watchdog-blink-watchlist_google.com, ed+blinkwatch_opera.com, Inactive, Nils Barth (inactive)
Visibility:
Public.

Description

Add use counters for a number of extensions and non-standard APIs Found by searching for "extension" and "non-standard" in *.idl. Some APIs which are documented as extension/non-standard in the IDL are now standardized, and no counters were added for those, like Document.readyState. Ad-hoc testing was done in Firefox and IE. It looks like the comments about IE/Mozilla/WebKit extensions are mostly accurate, and none of the touched APIs are implemented in both Firefox and IE. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173180

Patch Set 1 #

Patch Set 2 : measure HTMLPreElementWrap internally also #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -31 lines) Patch
M Source/core/dom/Document.idl View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Range.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/html/HTMLFrameElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLImageElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOptionsCollection.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPreElement.cpp View 1 2 chunks +5 lines, -2 lines 1 comment Download
M Source/core/html/HTMLPreElement.idl View 1 chunk +1 line, -1 line 2 comments Download
M Source/core/page/Selection.idl View 1 chunk +14 lines, -15 lines 0 comments Download
M Source/core/svg/SVGFEMorphologyElement.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
6 years, 7 months ago (2014-05-01 22:34:15 UTC) #1
eseidel
lgtm https://codereview.chromium.org/268663005/diff/20001/Source/core/html/HTMLPreElement.idl File Source/core/html/HTMLPreElement.idl (right): https://codereview.chromium.org/268663005/diff/20001/Source/core/html/HTMLPreElement.idl#newcode25 Source/core/html/HTMLPreElement.idl:25: [Reflect, MeasureAs=HTMLPreElementWrap] attribute boolean wrap; We don't have ...
6 years, 7 months ago (2014-05-02 00:32:10 UTC) #2
eseidel
6 years, 7 months ago (2014-05-02 00:32:19 UTC) #3
Nils Barth (inactive)
https://codereview.chromium.org/268663005/diff/20001/Source/core/html/HTMLPreElement.idl File Source/core/html/HTMLPreElement.idl (right): https://codereview.chromium.org/268663005/diff/20001/Source/core/html/HTMLPreElement.idl#newcode25 Source/core/html/HTMLPreElement.idl:25: [Reflect, MeasureAs=HTMLPreElementWrap] attribute boolean wrap; On 2014/05/02 00:32:10, eseidel ...
6 years, 7 months ago (2014-05-02 05:10:58 UTC) #4
eseidel
https://codereview.chromium.org/268663005/diff/20001/Source/core/html/HTMLPreElement.cpp File Source/core/html/HTMLPreElement.cpp (right): https://codereview.chromium.org/268663005/diff/20001/Source/core/html/HTMLPreElement.cpp#newcode57 Source/core/html/HTMLPreElement.cpp:57: UseCounter::count(document(), UseCounter::HTMLPreElementWrap); i see, I thought this was HTMLPreElement::parseAttribute, ...
6 years, 7 months ago (2014-05-02 05:14:08 UTC) #5
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 7 months ago (2014-05-02 05:55:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/268663005/20001
6 years, 7 months ago (2014-05-02 05:55:49 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 06:03:30 UTC) #8
Message was sent while issue was closed.
Change committed as 173180

Powered by Google App Engine
This is Rietveld 408576698