Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2851)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java

Issue 2686613003: [Payments] Move address normalization code from android to native. (Closed)
Patch Set: Renamed file and addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
index b4ee5f6dc3fcb24e75a08219fa2468bd1c33a1e7..9ba6f52c5f78c75da115440d4e7f4e386e1bda39 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
@@ -72,6 +72,14 @@ public class PersonalDataManager {
*/
@CalledByNative("NormalizedAddressRequestDelegate")
void onAddressNormalized(AutofillProfile profile);
+
+ /**
+ * Called when the address could not be normalized.
+ *
+ * @param profile The non normalized profile.
+ */
+ @CalledByNative("NormalizedAddressRequestDelegate")
+ void onCouldNotNormalize(AutofillProfile profile);
}
/**
@@ -811,20 +819,11 @@ public class PersonalDataManager {
* @param guid The GUID of the profile to normalize.
* @param regionCode The region code indicating which rules to use for normalization.
* @param delegate The object requesting the normalization.
- *
- * @return Whether the normalization will happen asynchronously.
*/
- public boolean normalizeAddress(
+ public void normalizeAddress(
String guid, String regionCode, NormalizedAddressRequestDelegate delegate) {
ThreadUtils.assertOnUiThread();
- return nativeStartAddressNormalization(
- mPersonalDataManagerAndroid, guid, regionCode, delegate);
- }
-
- /** Cancels the pending address normalizations. */
- public void cancelPendingAddressNormalizations() {
- ThreadUtils.assertOnUiThread();
- nativeCancelPendingAddressNormalizations(mPersonalDataManagerAndroid);
+ nativeStartAddressNormalization(mPersonalDataManagerAndroid, guid, regionCode, delegate);
}
/**
@@ -955,10 +954,8 @@ public class PersonalDataManager {
WebContents webContents, CreditCard card, FullCardRequestDelegate delegate);
private native void nativeLoadRulesForRegion(
long nativePersonalDataManagerAndroid, String regionCode);
- private native boolean nativeStartAddressNormalization(long nativePersonalDataManagerAndroid,
+ private native void nativeStartAddressNormalization(long nativePersonalDataManagerAndroid,
String guid, String regionCode, NormalizedAddressRequestDelegate delegate);
- private native void nativeCancelPendingAddressNormalizations(
- long nativePersonalDataManagerAndroid);
private static native boolean nativeHasProfiles(long nativePersonalDataManagerAndroid);
private static native boolean nativeHasCreditCards(long nativePersonalDataManagerAndroid);
private static native boolean nativeIsAutofillEnabled();
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698