Issue 2686573004: "Fix" kernel loop break to label test break to make tree green while investigating better fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2686573004: "Fix" kernel loop break to label test break to make tree green while investigating better fix. (Closed)

Created:
3 years, 10 months ago by Emily Fortuna

Modified:
3 years, 10 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

"Fix" kernel loop break to label test break to make tree green while investigating better fix. BUG=https://github.com/dart-lang/sdk/issues/28670 Committed: https://github.com/dart-lang/sdk/commit/e6cc14ec4e3e36e92d74198eca8987b7a8301ad2

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	tests/compiler/dart2js/kernel/loops_test.dart	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (2 generated)

Emily Fortuna

TBR to make tree green. I'm investigating a real fix now.

3 years, 10 months ago (2017-02-07 20:36:16 UTC) #2

Emily Fortuna

3 years, 10 months ago (2017-02-07 20:36:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e6cc14ec4e3e36e92d74198eca8987b7a8301ad2 (presubmit successful).