[ObjC ARC] Converts ios/chrome/browser/ui/stack_view:unit_tests to ARC.

ios/chrome/browser/ui/stack_view/stack_card_unittest.mm

Index: ios/chrome/browser/ui/stack_view/stack_card_unittest.mm
diff --git a/ios/chrome/browser/ui/stack_view/stack_card_unittest.mm b/ios/chrome/browser/ui/stack_view/stack_card_unittest.mm
index e2197c1c4976b2a5c114ac0b4e700897d17962a7..a84da6d516015d12a13fb6fed8e192a2539531b4 100644
--- a/ios/chrome/browser/ui/stack_view/stack_card_unittest.mm
+++ b/ios/chrome/browser/ui/stack_view/stack_card_unittest.mm
@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/mac/scoped_nsobject.h"
 #import "ios/chrome/browser/ui/rtl_geometry.h"
 #import "ios/chrome/browser/ui/stack_view/card_view.h"
 #import "ios/chrome/browser/ui/stack_view/stack_card.h"
@@ -11,6 +10,10 @@
 #include "testing/gtest_mac.h"
 #include "testing/platform_test.h"
 
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
 // Mocked-out CardView object
 @interface MockCardView : UIView
 @end
@@ -26,7 +29,7 @@
 
 @implementation MockCardViewProvider
 - (CardView*)cardViewWithFrame:(CGRect)frame forStackCard:(StackCard*)card {
-  return (CardView*)[[[MockCardView alloc] initWithFrame:frame] autorelease];
+  return (CardView*)[[MockCardView alloc] initWithFrame:frame];

[sdefresne, 2017/02/09 13:47:49]

static_cast

[lody, 2017/02/09 16:00:03]

Done.

 }
 @end
 
@@ -37,15 +40,14 @@ namespace {
 class StackCardTest : public PlatformTest {
  protected:
   void SetUp() override {
-    view_provider_.reset([[MockCardViewProvider alloc] init]);
+    view_provider_ = [[MockCardViewProvider alloc] init];
   }
 

[sdefresne, 2017/02/09 13:47:49]

PlatformTest drain it's autoreleasepool in ShutDown(), so either set
view_provider_ in ShutDown if necessary, or just change the initialisation to
happen in the constructor.

[lody, 2017/02/09 16:00:03]

Done.

-  base::scoped_nsobject<MockCardViewProvider> view_provider_;
+  MockCardViewProvider* view_provider_;
 };
 
 TEST_F(StackCardTest, LazyCreation) {
-  base::scoped_nsobject<StackCard> card(
-      [[StackCard alloc] initWithViewProvider:view_provider_]);
+  StackCard* card = [[StackCard alloc] initWithViewProvider:view_provider_];
   // Set attributes before asking for the view.
   LayoutRect layout = LayoutRectMake(10, 300, 20, 55, 98);
   CGRect frame = LayoutRectGetRect(layout);
@@ -61,8 +63,7 @@ TEST_F(StackCardTest, LazyCreation) {
 }
 
 TEST_F(StackCardTest, LiveViewUpdating) {
-  base::scoped_nsobject<StackCard> card(
-      [[StackCard alloc] initWithViewProvider:view_provider_]);
+  StackCard* card = [[StackCard alloc] initWithViewProvider:view_provider_];
   // Get the view, then set attributes.
   UIView* view = [card view];
   LayoutRect layout = LayoutRectMake(10, 300, 20, 55, 98);
@@ -76,8 +77,7 @@ TEST_F(StackCardTest, LiveViewUpdating) {
 }
 
 TEST_F(StackCardTest, BoundsUpdatePreservesCenter) {
-  base::scoped_nsobject<StackCard> card(
-      [[StackCard alloc] initWithViewProvider:view_provider_]);
+  StackCard* card = [[StackCard alloc] initWithViewProvider:view_provider_];
   LayoutRect layout = LayoutRectMake(0, 300, 0, 40, 100);
   CGRect frame = LayoutRectGetRect(layout);
   [card setLayout:layout];
@@ -89,8 +89,7 @@ TEST_F(StackCardTest, BoundsUpdatePreservesCenter) {
 }
 
 TEST_F(StackCardTest, PixelAlignmentOfViewFrameAfterLiveUpdate) {
-  base::scoped_nsobject<StackCard> card(
-      [[StackCard alloc] initWithViewProvider:view_provider_]);
+  StackCard* card = [[StackCard alloc] initWithViewProvider:view_provider_];
   // Get the view, then set attributes.
   UIView* view = [card view];
   const LayoutRectPosition kPosition = LayoutRectPositionMake(10.3, 20.4);
@@ -112,8 +111,7 @@ TEST_F(StackCardTest, PixelAlignmentOfViewFrameAfterLiveUpdate) {
 }
 
 TEST_F(StackCardTest, ViewFrameSynchronization) {
-  base::scoped_nsobject<StackCard> card(
-      [[StackCard alloc] initWithViewProvider:view_provider_]);
+  StackCard* card = [[StackCard alloc] initWithViewProvider:view_provider_];
   // Get the view, then set attributes.
   UIView* view = [card view];
   const LayoutRect kFirstLayout = LayoutRectMake(10, 300, 20, 55, 98);
@@ -148,8 +146,7 @@ TEST_F(StackCardTest, ViewFrameSynchronization) {
 }
 
 TEST_F(StackCardTest, ViewLayoutSynchronization) {
-  base::scoped_nsobject<StackCard> card(
-      [[StackCard alloc] initWithViewProvider:view_provider_]);
+  StackCard* card = [[StackCard alloc] initWithViewProvider:view_provider_];
   // Get the view, then set attributes.
   UIView* view = [card view];
   const LayoutRect kFirstLayout = LayoutRectMake(30, 300, 40, 200, 100);
@@ -185,8 +182,7 @@ TEST_F(StackCardTest, ViewLayoutSynchronization) {
 }
 
 TEST_F(StackCardTest, PixelAlignmentOfViewAfterSynchronization) {
-  base::scoped_nsobject<StackCard> card(
-      [[StackCard alloc] initWithViewProvider:view_provider_]);
+  StackCard* card = [[StackCard alloc] initWithViewProvider:view_provider_];
   // Get the view, then set attributes.
   UIView* view = [card view];
   const CGFloat kBoundingWidth = 300;