third_party/WebKit/Source/platform/heap/HeapTest.cpp - Issue 2686533003: Move postGC out of CrossThreadPersistentRegion::LockScope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/HeapTest.cpp

Issue 2686533003: Move postGC out of CrossThreadPersistentRegion::LockScope (Closed)

Patch Set: fix Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/heap/HeapTest.cpp

diff --git a/third_party/WebKit/Source/platform/heap/HeapTest.cpp b/third_party/WebKit/Source/platform/heap/HeapTest.cpp

index 9bda7c92564ec4b9977afc4f61b3aa8b9472646a..764d78e5e7166f4fc0dd921d5c8465d18db7aef1 100644

--- a/third_party/WebKit/Source/platform/heap/HeapTest.cpp

+++ b/third_party/WebKit/Source/platform/heap/HeapTest.cpp

@@ -283,7 +283,10 @@ class TestGCScope {

m_state->heap().preGC();

}

- ~TestGCScope() { m_state->heap().postGC(BlinkGC::GCWithSweep); }

+ ~TestGCScope() {

+ m_state->heap().postGC(BlinkGC::GCWithSweep);

+ m_state->heap().preSweep(BlinkGC::GCWithSweep);

+ }

private:

ThreadState* m_state;