Issue 268653004: [refactor] Replace shouldBeTrue("a != b") with shouldNotBe("a", "b") in existing crypto tests.

Issue 268653004: [refactor] Replace shouldBeTrue("a != b") with shouldNotBe("a", "b") in existing crypto tests. (Closed)

Created:
6 years, 7 months ago by eroman

Modified:
6 years, 7 months ago

Reviewers:
jsbell

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

[refactor] Replace shouldBeTrue("a != b") with shouldNotBe("a", "b") in existing crypto tests. The same changes were made for a new test in https://codereview.chromium.org/268273002; this fixes the older ones. Also fixes a typo in a comment, pointed out by same review. BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173444

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+232 lines, -231 lines)			Patch
M	LayoutTests/crypto/clone-aesKey.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/crypto/clone-aesKey-expected.txt	View	48 chunks	+48 lines, -48 lines	0 comments	Download
M	LayoutTests/crypto/clone-hmacKey.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/crypto/clone-hmacKey-expected.txt	View	48 chunks	+48 lines, -48 lines	0 comments	Download
M	LayoutTests/crypto/clone-rsaHashedKey-private.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/crypto/clone-rsaHashedKey-private-expected.txt	View	48 chunks	+48 lines, -48 lines	0 comments	Download
M	LayoutTests/crypto/clone-rsaHashedKey-public.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/crypto/clone-rsaHashedKey-public-expected.txt	View	48 chunks	+48 lines, -48 lines	0 comments	Download
M	LayoutTests/crypto/clone-rsaKey-private.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/crypto/clone-rsaKey-private-expected.txt	View	16 chunks	+16 lines, -16 lines	0 comments	Download
M	LayoutTests/crypto/clone-rsaKey-public.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/crypto/clone-rsaKey-public-expected.txt	View	16 chunks	+16 lines, -16 lines	0 comments	Download
M	LayoutTests/crypto/resources/subtle-crypto-concurrent.js	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

eroman

This is a follow-up to some problems you pointed out in my other review. Thanks!

6 years, 7 months ago (2014-05-06 21:52:36 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/268653004/1

6 years, 7 months ago (2014-05-06 22:25:43 UTC) #4

Message was sent while issue was closed.

Change committed as 173444