Add IPC ParamTraits for c-style arrays

ipc/ipc_message_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IPC_IPC_MESSAGE_UTILS_H_
 #define IPC_IPC_MESSAGE_UTILS_H_
 
 #include <limits.h>
 #include <stddef.h>
 #include <stdint.h>
@@ skipping 289 matching lines @@
 struct IPC_EXPORT ParamTraits<double> {
   typedef double param_type;
   static void GetSize(base::PickleSizer* sizer, const param_type& p);
   static void Write(base::Pickle* m, const param_type& p);
   static bool Read(const base::Pickle* m,
                    base::PickleIterator* iter,
                    param_type* r);
   static void Log(const param_type& p, std::string* l);
 };
 
+template <class P, size_t Size>
+struct ParamTraits<P[Size]> {
+  using param_type = P[Size];
+  static void GetSize(base::PickleSizer* sizer, const param_type& p) {
+    GetParamSize(sizer, base::checked_cast<int>(Size));

[ericrk, 2017/02/08 21:07:15]

Switched to checked_cast per your comment.

[Tom Sepez, 2017/02/09 17:14:37]

Why are we passing the size over the wire?  These templates apply to arrays of
known size, and we should just read/write the expected number of members.

[ericrk, 2017/02/09 22:02:08]

True enough, I guess I was thinking it was more robust against malformed data,
but it does seem pretty unlikely that this would help us. Removed.

+    for (size_t i = 0; i < Size; i++)
+      GetParamSize(sizer, p[i]);
+  }
+  static void Write(base::Pickle* m, const param_type& p) {
+    WriteParam(m, base::checked_cast<int>(Size));
+    for (size_t i = 0; i < Size; i++)

[Tom Sepez, 2017/02/09 17:17:10]

nit: can we use a range-based for loop and avoid having an index variable at
all?

[ericrk, 2017/02/09 22:02:08]

Yup, we can.

+      WriteParam(m, p[i]);
+  }
+  static bool Read(const base::Pickle* m,
+                   base::PickleIterator* iter,
+                   param_type* r) {
+    int size;
+    // ReadLength() checks for < 0 itself.
+    if (!iter->ReadLength(&size))
+      return false;
+    // For a fixed size array, a size mismatch indicates invalid data.
+    if (size != Size)
+      return false;
+    for (size_t i = 0; i < Size; i++) {
+      if (!ReadParam(m, iter, &(*r)[i]))
+        return false;
+    }
+    return true;
+  }
+  static void Log(const param_type& p, std::string* l) {
+    l->append("[");
+    for (size_t i = 0; i < Size; ++i) {
+      if (i != 0)
+        l->append(" ");
+      LogParam((p[i]), l);
+    }
+    l->append("]");
+  }
+};
+
 // STL ParamTraits -------------------------------------------------------------
 
 template <>
 struct ParamTraits<std::string> {
   typedef std::string param_type;
   static void GetSize(base::PickleSizer* sizer, const param_type& p) {
     sizer->AddString(p);
   }
   static void Write(base::Pickle* m, const param_type& p) { m->WriteString(p); }
   static bool Read(const base::Pickle* m,
@@ skipping 819 matching lines @@
 template <class ReplyParamType>
 inline void LogReplyParamsToMessage(const ReplyParamType& reply_params,
                                     const Message* msg) {}
 
 inline void ConnectMessageAndReply(const Message* msg, Message* reply) {}
 #endif
 
 }  // namespace IPC
 
 #endif  // IPC_IPC_MESSAGE_UTILS_H_