third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp - Issue 2686503003: Add support for shaping a substring to HarfBuzzShaper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp

Issue 2686503003: Add support for shaping a substring to HarfBuzzShaper (Closed)

Patch Set: Cleanup comments and adjust tolerance Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp b/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp

index 08041134784c18761eaf387b5d716b1c0edccd84..7019bc6a2dc0c103a816578c66b31768934b9c16 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp

@@ -18,9 +18,7 @@ RunSegmenter::RunSegmenter(const UChar* buffer,

unsigned bufferSize,

FontOrientation runOrientation)

: m_bufferSize(bufferSize),

- m_candidateRange({0, 0, USCRIPT_INVALID_CODE,

- OrientationIterator::OrientationKeep,

- FontFallbackPriority::Text}),

+ m_candidateRange(nullRange()),

m_scriptRunIterator(

WTF::makeUnique<ScriptRunIterator>(buffer, bufferSize)),

m_orientationIterator(