third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp - Issue 2686503003: Add support for shaping a substring to HarfBuzzShaper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp

Issue 2686503003: Add support for shaping a substring to HarfBuzzShaper (Closed)

Patch Set: Fix windows compiler error Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h » ('j') | third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp

index 4f17d0e0cc44f2b8df503d9eb5f284db45f5453b..4bd2a1fbfed48ce7e6ffa1ea85f2d8e66c91cf04 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.cpp

@@ -18,8 +18,9 @@ PassRefPtr<const ShapeResult> CachingWordShapeIterator::shapeWordWithoutSpacing(

unsigned wordLength = 0;

std::unique_ptr<UChar[]> wordText = wordRun.normalizedUTF16(&wordLength);

- HarfBuzzShaper shaper(wordText.get(), wordLength, wordRun.direction());

- RefPtr<const ShapeResult> shapeResult = shaper.shapeResult(font);

+ HarfBuzzShaper shaper(wordText.get(), wordLength);

+ RefPtr<const ShapeResult> shapeResult =

+ shaper.shape(font, wordRun.direction());

if (!shapeResult)

return nullptr;