Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 26865004: Use pages from lower to higher addresses in new space. (Closed)

Created:
7 years, 2 months ago by Hannes Payer (out of office)
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Use pages from lower to higher addresses in new space. This CL constitutes the invariant that the top pointer in new space is always larger than objects allocated since the last new space garbage collection. BUG= R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17185

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -21 lines) Patch
M src/spaces.cc View 1 2 3 chunks +12 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hannes Payer (out of office)
7 years, 2 months ago (2013-10-10 20:47:19 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/26865004/diff/1002/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/26865004/diff/1002/src/spaces.cc#newcode1532 src/spaces.cc:1532: NewSpacePage::Initialize(heap(), start_ + i * Page::kPageSize, this); nit: ...
7 years, 2 months ago (2013-10-14 09:03:51 UTC) #2
Hannes Payer (out of office)
https://codereview.chromium.org/26865004/diff/1002/src/spaces.cc File src/spaces.cc (right): https://codereview.chromium.org/26865004/diff/1002/src/spaces.cc#newcode1532 src/spaces.cc:1532: NewSpacePage::Initialize(heap(), start_ + i * Page::kPageSize, this); On 2013/10/14 ...
7 years, 2 months ago (2013-10-14 09:24:28 UTC) #3
Hannes Payer (out of office)
7 years, 2 months ago (2013-10-14 09:48:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r17185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698