Issue 26865003: Fix android NTP's scroll to top of page logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26865003: Fix android NTP's scroll to top of page logic. (Closed)

Created:
7 years, 2 months ago by Dan Beam

Modified:
7 years, 2 months ago

Reviewers:
Ted C

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix android NTP's scroll to top of page logic. Setting or reading document.body.scroll{Left,Top} is deprecated in favor of document.documentElement.scroll{Left,Top} in standards mode. R=tedchoc@chromium.org BUG=305742 TEST=on #hash change, android scrolls to top Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227958

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/ntp_android/ntp_android.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Dan Beam

don't know if this is relevant with the native NTP, but doesn't hurt to check

7 years, 2 months ago (2013-10-10 16:21:42 UTC) #1

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 2 months ago (2013-10-10 16:26:47 UTC) #3

Ted C

On 2013/10/10 16:26:47, I haz the power (commit-bot) wrote: > No LGTM from a valid ...

7 years, 2 months ago (2013-10-10 16:27:41 UTC) #4

Dan Beam

7 years, 2 months ago (2013-10-10 17:39:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r227958 (presubmit successful).