Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: chrome/browser/media/webrtc/media_stream_device_permission_context_unittest.cc

Issue 2686463002: Add a source to the result of PermissionContextBase::GetPermissionStatus (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/media_stream_device_permission_context_unittest.cc
diff --git a/chrome/browser/media/webrtc/media_stream_device_permission_context_unittest.cc b/chrome/browser/media/webrtc/media_stream_device_permission_context_unittest.cc
index e05705077b0dba53e1c1eae729654c843d76eda7..61a82197ae12d5cffad8262f5459c8eeb40751e7 100644
--- a/chrome/browser/media/webrtc/media_stream_device_permission_context_unittest.cc
+++ b/chrome/browser/media/webrtc/media_stream_device_permission_context_unittest.cc
@@ -74,10 +74,14 @@ class MediaStreamDevicePermissionContextTests
permission_type,
std::string()));
- EXPECT_EQ(CONTENT_SETTING_ASK, permission_context.GetPermissionStatus(
- insecure_url, insecure_url));
- EXPECT_EQ(CONTENT_SETTING_ASK,
- permission_context.GetPermissionStatus(insecure_url, secure_url));
+ PermissionResult result =
+ permission_context.GetPermissionStatus(insecure_url, insecure_url);
+ EXPECT_EQ(CONTENT_SETTING_ASK, result.content_setting);
+ EXPECT_EQ(PermissionStatusSource::UNSPECIFIED, result.source);
+
+ result = permission_context.GetPermissionStatus(insecure_url, secure_url);
+ EXPECT_EQ(CONTENT_SETTING_ASK, result.content_setting);
+ EXPECT_EQ(PermissionStatusSource::UNSPECIFIED, result.source);
}
void TestSecureQueryingUrl(ContentSettingsType permission_type) {
@@ -92,8 +96,10 @@ class MediaStreamDevicePermissionContextTests
permission_type,
std::string()));
- EXPECT_EQ(CONTENT_SETTING_ASK,
- permission_context.GetPermissionStatus(secure_url, secure_url));
+ PermissionResult result =
+ permission_context.GetPermissionStatus(secure_url, secure_url);
+ EXPECT_EQ(CONTENT_SETTING_ASK, result.content_setting);
+ EXPECT_EQ(PermissionStatusSource::UNSPECIFIED, result.source);
}
private:

Powered by Google App Engine
This is Rietveld 408576698