Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1272)

Side by Side Diff: net/quic/quic_stream_sequencer_test.cc

Issue 268643008: Cleanup: Remove redundant string conversions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sending for review Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | net/quic/test_tools/delayed_verify_strike_register_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_stream_sequencer.h" 5 #include "net/quic/quic_stream_sequencer.h"
6 6
7 #include <utility> 7 #include <utility>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 TEST_F(QuicSequencerRandomTest, RandomFramesNoDroppingNoBackup) { 374 TEST_F(QuicSequencerRandomTest, RandomFramesNoDroppingNoBackup) {
375 InSequence s; 375 InSequence s;
376 for (size_t i = 0; i < list_.size(); ++i) { 376 for (size_t i = 0; i < list_.size(); ++i) {
377 string* data = &list_[i].second; 377 string* data = &list_[i].second;
378 EXPECT_CALL(stream_, ProcessRawData(StrEq(*data), data->size())) 378 EXPECT_CALL(stream_, ProcessRawData(StrEq(*data), data->size()))
379 .WillOnce(Return(data->size())); 379 .WillOnce(Return(data->size()));
380 } 380 }
381 381
382 while (!list_.empty()) { 382 while (!list_.empty()) {
383 int index = OneToN(list_.size()) - 1; 383 int index = OneToN(list_.size()) - 1;
384 LOG(ERROR) << "Sending index " << index << " " 384 LOG(ERROR) << "Sending index " << index << " " << list_[index].second;
385 << list_[index].second.data();
386 EXPECT_TRUE(sequencer_->OnFrame(list_[index].first, 385 EXPECT_TRUE(sequencer_->OnFrame(list_[index].first,
387 list_[index].second.data())); 386 list_[index].second.data()));
388 387
389 list_.erase(list_.begin() + index); 388 list_.erase(list_.begin() + index);
390 } 389 }
391 } 390 }
392 391
393 } // namespace 392 } // namespace
394 } // namespace test 393 } // namespace test
395 } // namespace net 394 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | net/quic/test_tools/delayed_verify_strike_register_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698