Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1197)

Unified Diff: bench/gen_bench_expectations.py

Issue 268643004: further adjust bench lower bounds to cope with downside flakiness. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/gen_bench_expectations.py
diff --git a/bench/gen_bench_expectations.py b/bench/gen_bench_expectations.py
index ffc64866b609601f412ad589c98b48f6e0b21c16..e7d08d116f6d57b1712ef10f71ac4efd18cfa498 100644
--- a/bench/gen_bench_expectations.py
+++ b/bench/gen_bench_expectations.py
@@ -13,7 +13,7 @@ import sys
# Parameters for calculating bench ranges.
RANGE_RATIO_UPPER = 1.2 # Ratio of range for upper bounds.
-RANGE_RATIO_LOWER = 1.8 # Ratio of range for lower bounds.
+RANGE_RATIO_LOWER = 2.0 # Ratio of range for lower bounds.
ERR_RATIO = 0.08 # Further widens the range by the ratio of average value.
ERR_ABS = 0.5 # Adds an absolute error margin to cope with very small benches.
@@ -25,7 +25,7 @@ CONFIGS_TO_INCLUDE = ['simple_viewport_1000x1000',
]
# List of flaky SKPs that should be excluded.
-SKPS_TO_EXCLUDE = ['desk_chalkboard.skp',
+SKPS_TO_EXCLUDE = [
]
@@ -44,7 +44,7 @@ def compute_ranges(benches):
avg = sum(benches) / len(benches)
return [minimum - diff * RANGE_RATIO_LOWER - avg * ERR_RATIO - ERR_ABS,
- maximum + diff * RANGE_RATIO_UPPER + avg * ERR_RATIO + ERR_ABS]
+ maximum + diff * RANGE_RATIO_UPPER + avg * ERR_RATIO + 2 * ERR_ABS]
def create_expectations_dict(revision_data_points):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698