Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/search_engines/default_search_pref_migration.cc

Issue 268643002: Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Restore DSP origin change metric. Restore some naming and ordering. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/search_engines/default_search_pref_migration.cc
diff --git a/chrome/browser/search_engines/default_search_pref_migration.cc b/chrome/browser/search_engines/default_search_pref_migration.cc
index 5a33f5532ad8ee91d17e1a8dcf142024fec84f93..d7f5579133e051ebcb9ab578ede131e1c9d6543e 100644
--- a/chrome/browser/search_engines/default_search_pref_migration.cc
+++ b/chrome/browser/search_engines/default_search_pref_migration.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/search_engines/default_search_manager.h"
#include "chrome/browser/search_engines/template_url.h"
#include "chrome/browser/search_engines/template_url_service.h"
+#include "chrome/common/pref_names.h"
namespace {
@@ -29,6 +30,25 @@ scoped_ptr<TemplateURLData> LoadDefaultSearchProviderFromPrefs(
return legacy_dse_from_prefs.Pass();
}
+void ClearDefaultSearchProviderFromLegacyPrefs(PrefService* prefs) {
+ prefs->ClearPref(prefs::kDefaultSearchProviderName);
+ prefs->ClearPref(prefs::kDefaultSearchProviderKeyword);
+ prefs->ClearPref(prefs::kDefaultSearchProviderSearchURL);
+ prefs->ClearPref(prefs::kDefaultSearchProviderSuggestURL);
+ prefs->ClearPref(prefs::kDefaultSearchProviderInstantURL);
+ prefs->ClearPref(prefs::kDefaultSearchProviderImageURL);
+ prefs->ClearPref(prefs::kDefaultSearchProviderNewTabURL);
+ prefs->ClearPref(prefs::kDefaultSearchProviderSearchURLPostParams);
+ prefs->ClearPref(prefs::kDefaultSearchProviderSuggestURLPostParams);
+ prefs->ClearPref(prefs::kDefaultSearchProviderInstantURLPostParams);
+ prefs->ClearPref(prefs::kDefaultSearchProviderImageURLPostParams);
+ prefs->ClearPref(prefs::kDefaultSearchProviderIconURL);
+ prefs->ClearPref(prefs::kDefaultSearchProviderEncodings);
+ prefs->ClearPref(prefs::kDefaultSearchProviderPrepopulateID);
+ prefs->ClearPref(prefs::kDefaultSearchProviderAlternateURLs);
+ prefs->ClearPref(prefs::kDefaultSearchProviderSearchTermsReplacementKey);
+}
+
void MigrateDefaultSearchPref(PrefService* pref_service) {
DCHECK(pref_service);
@@ -56,8 +76,7 @@ void MigrateDefaultSearchPref(PrefService* pref_service) {
}
}
- // TODO(erikwright): Clear the legacy value when the modern value is the
- // authority.
+ ClearDefaultSearchProviderFromLegacyPrefs(pref_service);
}
void OnPrefsInitialized(PrefService* pref_service,

Powered by Google App Engine
This is Rietveld 408576698