Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5115)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 268643002: Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: D'oh. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index 64dbaa225f07c104dc9888602dd9b391436f4b98..f61e62478a4a00bb979e0a72fde5fc059ceaea1f 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -241,13 +241,6 @@ class OmniboxViewTest : public InProcessBrowserTest,
ui_test_utils::WaitForTemplateURLServiceToLoad(model);
ASSERT_TRUE(model->loaded());
- // Remove built-in template urls, like google.com, bing.com etc., as they
- // may appear as autocomplete suggests and interfere with our tests.
- model->SetUserSelectedDefaultSearchProvider(NULL);
- TemplateURLService::TemplateURLVector builtins = model->GetTemplateURLs();
- for (TemplateURLService::TemplateURLVector::const_iterator
- i = builtins.begin(); i != builtins.end(); ++i)
- model->Remove(*i);
TemplateURLData data;
data.short_name = ASCIIToUTF16(kSearchShortName);
@@ -259,6 +252,16 @@ class OmniboxViewTest : public InProcessBrowserTest,
data.SetKeyword(ASCIIToUTF16(kSearchKeyword2));
model->Add(new TemplateURL(profile, data));
+
+ // Remove built-in template urls, like google.com, bing.com etc., as they
+ // may appear as autocomplete suggests and interfere with our tests.
+ TemplateURLService::TemplateURLVector urls = model->GetTemplateURLs();
+ for (TemplateURLService::TemplateURLVector::const_iterator i = urls.begin();
+ i != urls.end();
+ ++i) {
+ if ((*i)->prepopulate_id() != 0)
+ model->Remove(*i);
+ }
}
void AddHistoryEntry(const TestHistoryEntry& entry, const Time& time) {

Powered by Google App Engine
This is Rietveld 408576698