Use the DefaultSearchManager as the exclusive authority on DSE, ignoring Web Data.

chrome/browser/search_engines/default_search_policy_handler_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/search_engines/default_search_manager.h"
 #include "chrome/browser/search_engines/default_search_policy_handler.h"
 #include "chrome/common/pref_names.h"
 #include "components/policy/core/browser/configuration_policy_pref_store.h"
 #include "components/policy/core/browser/configuration_policy_pref_store_test.h"
@@ skipping 109 matching lines @@
 // search URL, that all the elements have been given proper defaults.
 TEST_F(DefaultSearchPolicyHandlerTest, MinimallyDefined) {
   PolicyMap policy;
   policy.Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true), NULL);
   policy.Set(key::kDefaultSearchProviderSearchURL, POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER, base::Value::CreateStringValue(kSearchURL),
              NULL);
   UpdateProviderPolicy(policy);
 
-  const base::Value* value = NULL;
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderSearchURL, &value));
-  EXPECT_TRUE(base::StringValue(kSearchURL).Equals(value));
+  const base::Value* temp = NULL;
+  const base::DictionaryValue* dictionary;
+  std::string value;
+  const base::ListValue* list_value;

[Peter Kasting, 2014/05/07 23:38:29]

Nit: Declare these locals just above the first line that uses each, rather than
all in this block.

[erikwright (departed), 2014/05/08 12:46:24]

Done.

+  EXPECT_TRUE(store_->GetValue(kDefaultSearchProviderData, &temp));
+  temp->GetAsDictionary(&dictionary);
 
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderName, &value));
-  EXPECT_TRUE(base::StringValue(kHostName).Equals(value));
+  // Name and keyword should be derived from host.
+  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kURL, &value));
+  EXPECT_EQ(kSearchURL, value);
+  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kShortName, &value));
+  EXPECT_EQ(kHostName, value);
+  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kKeyword, &value));
+  EXPECT_EQ(kHostName, value);
 
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderKeyword, &value));
-  EXPECT_TRUE(base::StringValue(kHostName).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderSuggestURL,
-                               &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderIconURL, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderEncodings, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderInstantURL,
-                               &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderAlternateURLs,
-                             &value));
-  EXPECT_TRUE(base::ListValue().Equals(value));
-
+  // Everything else should be set to the default value.
   EXPECT_TRUE(
-      store_->GetValue(prefs::kDefaultSearchProviderSearchTermsReplacementKey,
-      &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderImageURL, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(
-      prefs::kDefaultSearchProviderSearchURLPostParams, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(
-      prefs::kDefaultSearchProviderSuggestURLPostParams, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(
-      prefs::kDefaultSearchProviderInstantURLPostParams, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(
-      prefs::kDefaultSearchProviderImageURLPostParams, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(
-      prefs::kDefaultSearchProviderNewTabURL, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-}
-
-// Checks that for a fully defined search policy, all elements have been
-// read properly.
-TEST_F(DefaultSearchPolicyHandlerTest, FullyDefined) {
-  PolicyMap policy;
-  BuildDefaultSearchPolicy(&policy);
-  UpdateProviderPolicy(policy);
-
-  const base::Value* value = NULL;
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderSearchURL, &value));
-  EXPECT_TRUE(base::StringValue(kSearchURL).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderName, &value));
-  EXPECT_TRUE(base::StringValue(kName).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderKeyword, &value));
-  EXPECT_TRUE(base::StringValue(kKeyword).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderSuggestURL,
-                               &value));
-  EXPECT_TRUE(base::StringValue(kSuggestURL).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderIconURL, &value));
-  EXPECT_TRUE(base::StringValue(kIconURL).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderEncodings, &value));
-  EXPECT_TRUE(base::StringValue("UTF-16;UTF-8").Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(
-      prefs::kDefaultSearchProviderAlternateURLs, &value));
-  EXPECT_TRUE(default_alternate_urls_.Equals(value));
-
+      dictionary->GetString(DefaultSearchManager::kSuggestionsURL, &value));
+  EXPECT_EQ(std::string(), value);
+  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kFaviconURL, &value));
+  EXPECT_EQ(std::string(), value);
   EXPECT_TRUE(
-      store_->GetValue(prefs::kDefaultSearchProviderSearchTermsReplacementKey,
-      &value));
-  EXPECT_TRUE(base::StringValue(kReplacementKey).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderImageURL, &value));
-  EXPECT_TRUE(base::StringValue(std::string(kImageURL)).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderImageURLPostParams,
-                               &value));
-  EXPECT_TRUE(base::StringValue(std::string(kImageParams)).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(
-      prefs::kDefaultSearchProviderSearchURLPostParams, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(
-      prefs::kDefaultSearchProviderSuggestURLPostParams, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-
-  EXPECT_TRUE(store_->GetValue(
-      prefs::kDefaultSearchProviderInstantURLPostParams, &value));
-  EXPECT_TRUE(base::StringValue(std::string()).Equals(value));
-}
-
-// Checks that if the default search policy is missing, that no elements of the
-// default search policy will be present.
-TEST_F(DefaultSearchPolicyHandlerTest, MissingUrl) {
-  PolicyMap policy;
-  BuildDefaultSearchPolicy(&policy);
-  policy.Erase(key::kDefaultSearchProviderSearchURL);
-  UpdateProviderPolicy(policy);
-
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderSearchURL, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderName, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderKeyword, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderSuggestURL, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderIconURL, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderEncodings, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderAlternateURLs,
-                                NULL));
-  EXPECT_FALSE(store_->GetValue(
-      prefs::kDefaultSearchProviderSearchTermsReplacementKey, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderImageURL, NULL));
-  EXPECT_FALSE(store_->GetValue(
-      prefs::kDefaultSearchProviderImageURLPostParams, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderInstantURL, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderNewTabURL, NULL));
-}
-
-// Checks that if the default search policy is invalid, that no elements of the
-// default search policy will be present.
-TEST_F(DefaultSearchPolicyHandlerTest, Invalid) {
-  PolicyMap policy;
-  BuildDefaultSearchPolicy(&policy);
-  const char bad_search_url[] = "http://test.com/noSearchTerms";
-  policy.Set(key::kDefaultSearchProviderSearchURL, POLICY_LEVEL_MANDATORY,
-             POLICY_SCOPE_USER,
-             base::Value::CreateStringValue(bad_search_url), NULL);
-  UpdateProviderPolicy(policy);
-
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderSearchURL, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderName, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderKeyword, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderSuggestURL, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderIconURL, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderEncodings, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderAlternateURLs,
-                                NULL));
-  EXPECT_FALSE(store_->GetValue(
-      prefs::kDefaultSearchProviderSearchTermsReplacementKey, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderImageURL, NULL));
-  EXPECT_FALSE(store_->GetValue(
-      prefs::kDefaultSearchProviderImageURLPostParams, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderInstantURL, NULL));
-  EXPECT_FALSE(store_->GetValue(prefs::kDefaultSearchProviderNewTabURL, NULL));
-}
-
-// Checks that if the default search policy is invalid, that no elements of the
-// default search policy will be present.
-TEST_F(DefaultSearchPolicyHandlerTest, Disabled) {
-  PolicyMap policy;
-  policy.Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY,
-             POLICY_SCOPE_USER, base::Value::CreateBooleanValue(false), NULL);
-  UpdateProviderPolicy(policy);
-
-  const base::Value* value = NULL;
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderEnabled, &value));
-  base::FundamentalValue expected_enabled(false);
-  EXPECT_TRUE(base::Value::Equals(&expected_enabled, value));
-  EXPECT_TRUE(store_->GetValue(prefs::kDefaultSearchProviderSearchURL, &value));
-  base::StringValue expected_search_url((std::string()));
-  EXPECT_TRUE(base::Value::Equals(&expected_search_url, value));
+      dictionary->GetList(DefaultSearchManager::kInputEncodings, &list_value));
+  EXPECT_TRUE(base::ListValue().Equals(list_value));
+  EXPECT_TRUE(
+      dictionary->GetList(DefaultSearchManager::kAlternateURLs, &list_value));
+  EXPECT_TRUE(base::ListValue().Equals(list_value));
+  EXPECT_TRUE(dictionary->GetString(
+      DefaultSearchManager::kSearchTermsReplacementKey, &value));
+  EXPECT_EQ(std::string(), value);
+  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kImageURL, &value));
+  EXPECT_EQ(std::string(), value);
+  EXPECT_TRUE(
+      dictionary->GetString(DefaultSearchManager::kImageURLPostParams, &value));
+  EXPECT_EQ(std::string(), value);
+  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kSearchURLPostParams,
+                                    &value));
+  EXPECT_EQ(std::string(), value);
+  EXPECT_TRUE(dictionary->GetString(
+      DefaultSearchManager::kSuggestionsURLPostParams, &value));
+  EXPECT_EQ(std::string(), value);
+  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kInstantURLPostParams,
+                                    &value));
+  EXPECT_EQ(std::string(), value);
 }
 
 // Checks that for a fully defined search policy, all elements have been
 // read properly into the dictionary pref.
-TEST_F(DefaultSearchPolicyHandlerTest, DictionaryPref) {
+TEST_F(DefaultSearchPolicyHandlerTest,FullyDefined) {
   PolicyMap policy;
   BuildDefaultSearchPolicy(&policy);
   UpdateProviderPolicy(policy);
 
   const base::Value* temp = NULL;
   const base::DictionaryValue* dictionary;
   std::string value;
   const base::ListValue* list_value;
   EXPECT_TRUE(store_->GetValue(kDefaultSearchProviderData, &temp));
   temp->GetAsDictionary(&dictionary);
@@ skipping 40 matching lines @@
 
   EXPECT_TRUE(dictionary->GetString(
       DefaultSearchManager::kSuggestionsURLPostParams, &value));
   EXPECT_EQ(std::string(), value);
 
   EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kInstantURLPostParams,
                                     &value));
   EXPECT_EQ(std::string(), value);
 }
 
-// Checks that disabling default search is properly reflected the dictionary
-// pref.
-TEST_F(DefaultSearchPolicyHandlerTest, DictionaryPrefDSEDisabled) {
+// Checks that if the default search policy is missing, that no elements of the
+// default search policy will be present.
+TEST_F(DefaultSearchPolicyHandlerTest, MissingUrl) {
+  PolicyMap policy;
+  BuildDefaultSearchPolicy(&policy);
+  policy.Erase(key::kDefaultSearchProviderSearchURL);
+  UpdateProviderPolicy(policy);
+
+  const base::Value* temp = NULL;
+  EXPECT_FALSE(store_->GetValue(kDefaultSearchProviderData, &temp));
+}
+
+// Checks that if the default search policy is invalid, that no elements of the
+// default search policy will be present.
+TEST_F(DefaultSearchPolicyHandlerTest, Invalid) {
+  PolicyMap policy;
+  BuildDefaultSearchPolicy(&policy);
+  const char bad_search_url[] = "http://test.com/noSearchTerms";
+  policy.Set(key::kDefaultSearchProviderSearchURL, POLICY_LEVEL_MANDATORY,
+             POLICY_SCOPE_USER,
+             base::Value::CreateStringValue(bad_search_url), NULL);
+  UpdateProviderPolicy(policy);
+
+  const base::Value* temp = NULL;
+  EXPECT_FALSE(store_->GetValue(kDefaultSearchProviderData, &temp));
+}
+
+// Checks that disabling default search is properly reflected in the pref.
+TEST_F(DefaultSearchPolicyHandlerTest, Disabled) {
   PolicyMap policy;
   policy.Set(key::kDefaultSearchProviderEnabled,
              POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER,
              base::Value::CreateBooleanValue(false),
              NULL);
   UpdateProviderPolicy(policy);
   const base::Value* temp = NULL;
   const base::DictionaryValue* dictionary;
   EXPECT_TRUE(store_->GetValue(kDefaultSearchProviderData, &temp));
   temp->GetAsDictionary(&dictionary);
   bool disabled = false;
   EXPECT_TRUE(dictionary->GetBoolean(DefaultSearchManager::kDisabledByPolicy,
                                      &disabled));
   EXPECT_TRUE(disabled);
 }
 
-// Checks that if the policy for default search is valid, i.e. there's a
-// search URL, that all the elements have been given proper defaults.
-TEST_F(DefaultSearchPolicyHandlerTest, DictionaryPrefMinimallyDefined) {
+// Checks that setting a file URL as the default search is reflected properly in
+// the pref.
+TEST_F(DefaultSearchPolicyHandlerTest, FileURL) {
   PolicyMap policy;
   policy.Set(key::kDefaultSearchProviderEnabled,
              POLICY_LEVEL_MANDATORY,
-             POLICY_SCOPE_USER,
-             base::Value::CreateBooleanValue(true),
-             NULL);
-  policy.Set(key::kDefaultSearchProviderSearchURL,
-             POLICY_LEVEL_MANDATORY,
-             POLICY_SCOPE_USER,
-             base::Value::CreateStringValue(kSearchURL),
-             NULL);
-  UpdateProviderPolicy(policy);
-
-  const base::Value* temp = NULL;
-  const base::DictionaryValue* dictionary;
-  std::string value;
-  const base::ListValue* list_value;
-  EXPECT_TRUE(store_->GetValue(kDefaultSearchProviderData, &temp));
-  temp->GetAsDictionary(&dictionary);
-
-  // Name and keyword should be derived from host.
-  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kURL, &value));
-  EXPECT_EQ(kSearchURL, value);
-  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kShortName, &value));
-  EXPECT_EQ(kHostName, value);
-  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kKeyword, &value));
-  EXPECT_EQ(kHostName, value);
-
-  // Everything else should be set to the default value.
-  EXPECT_TRUE(
-      dictionary->GetString(DefaultSearchManager::kSuggestionsURL, &value));
-  EXPECT_EQ(std::string(), value);
-  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kFaviconURL, &value));
-  EXPECT_EQ(std::string(), value);
-  EXPECT_TRUE(
-      dictionary->GetList(DefaultSearchManager::kInputEncodings, &list_value));
-  EXPECT_TRUE(base::ListValue().Equals(list_value));
-  EXPECT_TRUE(
-      dictionary->GetList(DefaultSearchManager::kAlternateURLs, &list_value));
-  EXPECT_TRUE(base::ListValue().Equals(list_value));
-  EXPECT_TRUE(dictionary->GetString(
-      DefaultSearchManager::kSearchTermsReplacementKey, &value));
-  EXPECT_EQ(std::string(), value);
-  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kImageURL, &value));
-  EXPECT_EQ(std::string(), value);
-  EXPECT_TRUE(
-      dictionary->GetString(DefaultSearchManager::kImageURLPostParams, &value));
-  EXPECT_EQ(std::string(), value);
-  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kSearchURLPostParams,
-                                    &value));
-  EXPECT_EQ(std::string(), value);
-  EXPECT_TRUE(dictionary->GetString(
-      DefaultSearchManager::kSuggestionsURLPostParams, &value));
-  EXPECT_EQ(std::string(), value);
-  EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kInstantURLPostParams,
-                                    &value));
-  EXPECT_EQ(std::string(), value);
-}
-
-// Checks that setting a file URL as the default search is reflected properly in
-// the dictionary pref.
-TEST_F(DefaultSearchPolicyHandlerTest, DictionaryPrefFileURL) {
-  PolicyMap policy;
-  policy.Set(key::kDefaultSearchProviderEnabled,
-             POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER,
              base::Value::CreateBooleanValue(true),
              NULL);
   policy.Set(key::kDefaultSearchProviderSearchURL,
              POLICY_LEVEL_MANDATORY,
              POLICY_SCOPE_USER,
              base::Value::CreateStringValue(kFileSearchURL),
              NULL);
   UpdateProviderPolicy(policy);
 
   const base::Value* temp = NULL;
   const base::DictionaryValue* dictionary;
   std::string value;
 
   EXPECT_TRUE(store_->GetValue(kDefaultSearchProviderData, &temp));
   temp->GetAsDictionary(&dictionary);
 
   EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kURL, &value));
   EXPECT_EQ(kFileSearchURL, value);
   EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kShortName, &value));
   EXPECT_EQ("_", value);
   EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kKeyword, &value));
   EXPECT_EQ("_", value);
 }
 }  // namespace policy