chrome/browser/resources/settings/android_apps_page/android_apps_page.html - Issue 2686423002: MD Settings: improve play store learn more link position

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/android_apps_page/android_apps_page.html

Issue 2686423002: MD Settings: improve play store learn more link position (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/android_apps_page/android_apps_page.html

diff --git a/chrome/browser/resources/settings/android_apps_page/android_apps_page.html b/chrome/browser/resources/settings/android_apps_page/android_apps_page.html

index 9a38e2073b8743521bec832eb75560156ae652a9..b488c065e54385ed40955f8f0d5e10cca3efa86e 100644

--- a/chrome/browser/resources/settings/android_apps_page/android_apps_page.html

+++ b/chrome/browser/resources/settings/android_apps_page/android_apps_page.html

@@ -26,10 +26,11 @@

label="$i18n{androidAppsEnabled}"

on-change="onArcEnabledChange_"

no-set-pref>

+ <a href="$i18nRaw{androidAppsLearnMoreUrl}" target="_blank"

+ class="more-actions" on-tap="stopPropagation_">

tommycli 2017/02/13 16:20:11 stopPropagation i assume is to prevent the link cl

Dan Beam 2017/02/14 06:21:33 yes

+ $i18n{androidAppsLearnMore}

+ </a>

</settings-toggle-button>

- <a href="$i18nRaw{androidAppsLearnMoreUrl}" target="_blank">

- $i18n{androidAppsLearnMore}

- </a>

</div>

<div id="manageApps" class="settings-box continuation indented"

« no previous file with comments | « no previous file | chrome/browser/resources/settings/android_apps_page/android_apps_page.js » ('j') | no next file with comments »