Issue 2686343002: Fix inconsistent use of CodeSourceMap for stack traces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2686343002: Fix inconsistent use of CodeSourceMap for stack traces. (Closed)

Created:
3 years, 10 months ago by rmacnak

Modified:
3 years, 10 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix inconsistent use of CodeSourceMap for stack traces. Generation of this metadata is guarded by FLAG_precompiled_mode but use was guarded by FLAG_precompiled_runtime, leading to missing data for stack traces during AOT compilation. Closes #28739 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/36c79ea3e868affcb959c2f9535465de45711aec

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/vm/object.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 10 months ago (2017-02-10 20:41:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
36c79ea3e868affcb959c2f9535465de45711aec (presubmit successful).