Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

Issue 2686303003: webkitpy: Remove --run-chunk and --run-part. (Closed)
Patch Set: webkitpy: Remove --run-chunk and --run-part. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
index fde3371297696bf3b13c4d8e59aee70a43eb60a6..7e7bd00b0d0f0a1f5fb26aa48f48e01793b2ae4d 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
@@ -362,12 +362,6 @@ def parse_args(args):
help=("Number of times to retry failures, default is 3. Only relevant when "
"failure retries are enabled.")),
optparse.make_option(
- "--run-chunk",
- help="Run a specified chunk (n:l), the nth of len l, of the layout tests"),
- optparse.make_option(
- "--run-part",
- help="Run a specified part (n:m), the nth of m parts, of the layout tests"),
- optparse.make_option(
"--total-shards",
type=int,
help=('Total number of shards being used for this test run. '
@@ -545,14 +539,10 @@ def _set_up_derived_options(port, options, args):
if not options.skipped:
options.skipped = 'default'
- if not options.run_part:
- if not options.total_shards and 'GTEST_TOTAL_SHARDS' in port.host.environ:
- options.total_shards = int(port.host.environ['GTEST_TOTAL_SHARDS']) + 1
- if not options.shard_index and 'GTEST_SHARD_INDEX' in port.host.environ:
- options.shard_index = int(port.host.environ['GTEST_SHARD_INDEX'])
- if options.shard_index is not None and options.total_shards is not None:
- options.run_part = '%d:%d' % (int(options.shard_index) + 1,
- int(options.total_shards))
+ if not options.total_shards and 'GTEST_TOTAL_SHARDS' in port.host.environ:
+ options.total_shards = int(port.host.environ['GTEST_TOTAL_SHARDS'])
+ if not options.shard_index and 'GTEST_SHARD_INDEX' in port.host.environ:
+ options.shard_index = int(port.host.environ['GTEST_SHARD_INDEX'])
if not options.seed:
options.seed = port.host.time()

Powered by Google App Engine
This is Rietveld 408576698