Issue 2686293002: Use Keyword.isPseudo to translate Fasta's "pseudo-keywords" properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2686293002: Use Keyword.isPseudo to translate Fasta's "pseudo-keywords" properly. (Closed)

Created:
3 years, 10 months ago by Paul Berry

Modified:
3 years, 10 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Use Keyword.isPseudo to translate Fasta's "pseudo-keywords" properly. With the exception of `deferred`, all of Fasta's "pseudo-keywords" are considered by the analyzer (and the spec) to be identifiers. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/7e283248e19bf769b6fe5ac15f8232a9027f7e00

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -13 lines)			Patch
	M	pkg/front_end/lib/src/fasta/analyzer/token_utils.dart	View		2 chunks	+11 lines, -13 lines	0 comments	Download
	M	pkg/front_end/test/scanner_test.dart	View		6 chunks	+32 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 10 months ago (2017-02-10 18:59:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7e283248e19bf769b6fe5ac15f8232a9027f7e00 (presubmit successful).