Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: tests/compiler/dart2js/kernel/impact_test.dart

Issue 2686243004: Handler the last native annotations (Closed)
Patch Set: Cleanup. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/kernel/impact_test.dart
diff --git a/tests/compiler/dart2js/kernel/impact_test.dart b/tests/compiler/dart2js/kernel/impact_test.dart
index ccfce70f8ee8b2e7c933f0ebdaf6c46ef2c17b56..9ae1b5615cd0e1627130e8f9c75d53371145920d 100644
--- a/tests/compiler/dart2js/kernel/impact_test.dart
+++ b/tests/compiler/dart2js/kernel/impact_test.dart
@@ -34,8 +34,14 @@ const Map<String, String> SOURCE = const <String, String>{
import 'dart:_foreign_helper';
import 'dart:_js_helper';
import 'dart:_interceptors';
-import 'helper.dart';
+import 'dart:_native_typed_data';
+import 'dart:indexed_db';
import 'dart:html';
+import 'dart:html_common';
+import 'dart:math';
+import 'dart:typed_data';
+import 'dart:web_sql';
+import 'helper.dart';
main() {
testEmpty();
@@ -614,8 +620,10 @@ testInstanceGenericMethod() {
}
testDynamicPrivateMethodInvoke([o]) => o._privateMethod();
-testJSCall() => JS('int|bool', '#', null);
+testJSCall() => JS('int|bool|NativeUint8List|Rectangle|IdbFactory|'
+ 'SqlDatabase|TypedData|ContextAttributes', '#', null);
@JSName('foo')
+@SupportedBrowser(SupportedBrowser.CHROME)
testNativeMethod() native;
@Creates('int|Null|JSArray')
testNativeMethodCreates() native;
@@ -665,12 +673,7 @@ class GenericSub<X, Y> extends GenericSuper<X, Y>
with GenericMixin1<X, Y>, GenericMixin2<X, Y> {}
class GenericNamedMixin<X, Y> = GenericSuper<X, Y>
with GenericMixin1<X, Y>, GenericMixin2<X, Y>;
-
-const String _serializedScriptValue =
- 'num|String|bool|'
- 'JSExtendableArray|=Object';
-const annotation_Creates_SerializedScriptValue =
- const Creates(_serializedScriptValue);''',
Siggi Cherem (dart-lang) 2017/02/10 23:00:54 revert? this annotation is still used in NativeCla
Johnni Winther 2017/02/12 09:51:49 Yes, but now it's directly accessible through impo
+''',
};
main(List<String> args) {

Powered by Google App Engine
This is Rietveld 408576698