Handler the last native annotations

Handler the last native annotations

- we now handle `kernel/impact_test.dart --full`.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/69e97a27f31d57f85a3694b2c53674480a7af479

[Johnni Winther, 2017-02-10 15:07:38]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-02-10 23:00:54]

lgtm after addressing the comment on the test

https://codereview.chromium.org/2686243004/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/element_adapter.dart (right):

https://codereview.chromium.org/2686243004/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_adapter.dart:284: type ??=
findIn(Uris.dart_web_sql);
It would be nice if we could make the sequence of lookups more direct/narrow
depending on the library that contains them.

For example, do we ever have a reference from web_sql to something in svg? If
not, maybe we don't need to do the lookup there in that case.

We could encode this in a map:
Uri (library) => List<Uri> (list of libraries where to do lookup, in order of
likelyhood)

but eventually we could also derive such much from the import graph.

Thoughts? Maybe add a TODO?

https://codereview.chromium.org/2686243004/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/kernel/impact_test.dart (left):

https://codereview.chromium.org/2686243004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/impact_test.dart:673: const
Creates(_serializedScriptValue);''',
revert? this annotation is still used in NativeClass.field above...

[Johnni Winther, 2017-02-12 09:51:49]

https://codereview.chromium.org/2686243004/diff/20001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/element_adapter.dart (right):

https://codereview.chromium.org/2686243004/diff/20001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_adapter.dart:284: type ??=
findIn(Uris.dart_web_sql);
On 2017/02/10 23:00:54, Siggi Cherem (dart-lang) wrote:
> It would be nice if we could make the sequence of lookups more direct/narrow
> depending on the library that contains them.
> 
> For example, do we ever have a reference from web_sql to something in svg? If
> not, maybe we don't need to do the lookup there in that case.
> 
> We could encode this in a map:
> Uri (library) => List<Uri> (list of libraries where to do lookup, in order of
> likelyhood)
> 
> but eventually we could also derive such much from the import graph.
> 
> Thoughts? Maybe add a TODO?

Add a TODO.

https://codereview.chromium.org/2686243004/diff/20001/tests/compiler/dart2js/...
File tests/compiler/dart2js/kernel/impact_test.dart (left):

https://codereview.chromium.org/2686243004/diff/20001/tests/compiler/dart2js/...
tests/compiler/dart2js/kernel/impact_test.dart:673: const
Creates(_serializedScriptValue);''',
On 2017/02/10 23:00:54, Siggi Cherem (dart-lang) wrote:
> revert? this annotation is still used in NativeClass.field above... 

Yes, but now it's directly accessible through imports.

[Johnni Winther, 2017-02-12 09:58:42]

Description was changed from

==========
Handler the last native annotations

- we now handle `kernel/impact_test.dart --full`.
==========

to

==========
Handler the last native annotations

- we now handle `kernel/impact_test.dart --full`.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/69e97a27f31d57f85a3694b2c53674480a7af479
==========

[Johnni Winther, 2017-02-12 09:58:44]

Committed patchset #2 (id:20001) manually as
69e97a27f31d57f85a3694b2c53674480a7af479 (presubmit successful).