Add managed device signal

chrome/browser/chromeos/extensions/info_private_apitest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/values.h"
+#include "chrome/browser/browser_process.h"

[tbarzic, 2017/02/22 02:18:35]

nit: this is not needed, is it?

[Wenzhao (Colin) Zang, 2017/02/22 03:11:06]

Done.

 #include "chrome/browser/chromeos/arc/arc_util.h"
+#include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
+#include "chrome/browser/chromeos/settings/stub_install_attributes.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chromeos/settings/cros_settings_names.h"
 #include "components/arc/arc_util.h"
 #include "components/prefs/pref_service.h"
 
 namespace {
 
 const char kTestAppId[] = "ljoammodoonkhnehlncldjelhidljdpi";
@@ skipping 87 matching lines @@
   // Even if ARC is available, ARC may not be able to be enabled. (Please
   // see arc::IsArcAllowedForProfile() for details).
   // In such cases, we expect "available". However, current testing framework
   // does not seem to run with such cases, unfortunately. So, here directly
   // control the function.
   arc::DisallowArcForTesting();
   ASSERT_TRUE(RunPlatformAppTestWithArg("chromeos_info_private/extended",
                                         "arc available"))
       << message_;
 }
+
+class ChromeOSManagedDeviceInfoPrivateTest : public ChromeOSInfoPrivateTest {
+ public:
+  ChromeOSManagedDeviceInfoPrivateTest() = default;
+  ~ChromeOSManagedDeviceInfoPrivateTest() override = default;
+
+ protected:
+  void SetUpInProcessBrowserTestFixture() override {
+    // Set up fake install attributes.
+    std::unique_ptr<chromeos::StubInstallAttributes> attributes =
+        base::MakeUnique<chromeos::StubInstallAttributes>();
+    attributes->SetEnterprise("fake-domain", "fake-id");
+    policy::BrowserPolicyConnectorChromeOS::SetInstallAttributesForTesting(
+        attributes.release());
+    ChromeOSInfoPrivateTest::SetUpInProcessBrowserTestFixture();
+  }

[tbarzic, 2017/02/22 02:18:35]

nit: add DISALLOW_COPY_AND_ASSIGN

[Wenzhao (Colin) Zang, 2017/02/22 03:11:07]

Done.

+};
+
+IN_PROC_BROWSER_TEST_F(ChromeOSManagedDeviceInfoPrivateTest, Managed) {

[Rahul Chaturvedi, 2017/02/22 00:00:13]

Nit: You want to test all the code paths here. This only checks if a device is
managed so you should add a check for unmanaged also.

[Wenzhao (Colin) Zang, 2017/02/22 00:39:04]

The unmanaged value is default and the code path has been covered by
TestGetAndSet, and  the unmanaged test requires different setup (i.e. shouldn't
have policy::BrowserPolicyConnectorChromeOS::SetInstallAttributesForTesting()),
so it has to be put in a different class I think? Because we cannot reverse what
has been done in SetUpInProcessBrowserTestFixture()? I tried putting the setup
in the test body but it didn't work.

+  // The default status is not managed, which is tested by
+  // ChromeOSInfoPrivateTest.
+  ASSERT_TRUE(
+      RunPlatformAppTestWithArg("chromeos_info_private/extended", "managed"))
+      << message_;
+}