Issue 268623009: Introduce enablePreciseMemoryInfo switch and apply it to both renderer and shared worker

Issue 268623009: Introduce enablePreciseMemoryInfo switch and apply it to both renderer and shared worker (Closed)

Created:
6 years, 7 months ago by Pan

Modified:
6 years, 7 months ago

Reviewers:
tonyg, jam, abarth-chromium

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Introduce enablePreciseMemoryInfo switch and apply it to both renderer and shared worker BUG=326370 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268040

Patch Set 2 : for landing #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -12 lines)			Patch
M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/worker_host/worker_process_host.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/child/runtime_features.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	content/worker/websharedworker_stub.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Pan

Hi @jam, It is "kEnableSharedWorkerMemoryInfo " in https://codereview.chromium.org/183153002/, while, considering we need good granular info ...

6 years, 7 months ago (2014-05-02 16:31:20 UTC) #1

jam

lgtm with nit https://codereview.chromium.org/268623009/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/268623009/diff/1/content/public/common/content_switches.h#newcode150 content/public/common/content_switches.h:150: extern const char kEnablePreciseMemoryInfo[]; nit: here ...

6 years, 7 months ago (2014-05-02 18:38:03 UTC) #2

Pan

https://codereview.chromium.org/268623009/diff/1/content/public/common/content_switches.h File content/public/common/content_switches.h (right): https://codereview.chromium.org/268623009/diff/1/content/public/common/content_switches.h#newcode150 content/public/common/content_switches.h:150: extern const char kEnablePreciseMemoryInfo[]; On 2014/05/02 18:38:03, jam wrote: ...

6 years, 7 months ago (2014-05-03 00:01:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pan.deng@intel.com/268623009/20001

6 years, 7 months ago (2014-05-03 02:58:34 UTC) #5

Message was sent while issue was closed.

Change committed as 268040

Expand Messages | Collapse Messages