Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 268623003: Revert of Do not initialize v8::Context on |ScriptController::updateDocument|. (Closed)

Created:
6 years, 7 months ago by kouhei (in TOK)
Modified:
6 years, 7 months ago
CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Visibility:
Public.

Description

Revert of Do not initialize v8::Context on |ScriptController::updateDocument|. (https://codereview.chromium.org/263583002/) Reason for revert: broke interactive_ui_tests: Referrer SearchReusesInstantTab TypedSearchURLDoesntReuseInstantTab Original issue's description: > Do not initialize |v8::Context| on |ScriptController::updateDocument|. > > Initializing |v8::Context| is a heavy operation, and should be avoided if necessary. This is meant to be delayed until first time |toV8Context| is called, but |ScriptController::updateDocument| was forcing creation. > > This patch fixes the if branch so that it would not create a |v8::Context| if it does not exist. > > BUG=368548, 368555 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173044 TBR=haraken@chromium.org,jochen@chromium.org,dcarney@chromium.org NOTREECHECKS=true NOTRY=true BUG=368548, 368555 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173060

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M Source/bindings/v8/ScriptController.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/testing/v8/WebCoreTestSupport.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kouhei (in TOK)
Created Revert of Do not initialize v8::Context on |ScriptController::updateDocument|.
6 years, 7 months ago (2014-05-01 04:22:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/268623003/1
6 years, 7 months ago (2014-05-01 04:22:20 UTC) #2
haraken
LGTM
6 years, 7 months ago (2014-05-01 04:22:34 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-01 04:22:58 UTC) #4
Message was sent while issue was closed.
Change committed as 173060

Powered by Google App Engine
This is Rietveld 408576698