Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2686193003: [M57] Limit parsing recursion levels in CPDF_StreamParser (Closed)

Created:
3 years, 10 months ago by npm
Modified:
3 years, 10 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/chromium/2987
Project:
pdfium
Visibility:
Public.

Description

[M57] Limit parsing recursion levels in CPDF_StreamParser We currently only limit the array recursion levels. This recursion level may also be reset when parsing. This is insufficient to protect against stack overflows. BUG=681920 TBR=dsinclair@chromium.org, tsepez@chromium.org Change-Id: I69bd0c912fb45c0e68b9b9fa961d43f0adc9bdd3 Reviewed-on: https://pdfium-review.googlesource.com/2434 Commit-Queue: Nicolás Peña <npm@chromium.org>; Reviewed-by: Tom Sepez <tsepez@chromium.org>; (cherry picked from commit 6438c4f36da162f72e0d53e8fff45cd6687b7f5c) Committed: https://pdfium.googlesource.com/pdfium/+/6058ea2afb83b07834bd0fcb275c2934a60ffcaa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M core/fpdfapi/page/cpdf_streamcontentparser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_streamparser.h View 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_streamparser.cpp View 5 chunks +10 lines, -9 lines 0 comments Download
M testing/libfuzzer/pdf_streamparser_fuzzer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2686193003/1
3 years, 10 months ago (2017-02-10 20:47:18 UTC) #7
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-10 20:47:20 UTC) #9
npm
3 years, 10 months ago (2017-02-10 20:47:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6058ea2afb83b07834bd0fcb275c2934a60ffcaa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698