Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: content/renderer/media/webmediaplayer_ms_compositor.cc

Issue 2686173003: Remove uses of skia::GetWritablePixels(PaintCanvas) (Closed)
Patch Set: Add more deps Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/media/webmediaplayer_ms_compositor.h" 5 #include "content/renderer/media/webmediaplayer_ms_compositor.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/hash.h" 11 #include "base/hash.h"
12 #include "base/single_thread_task_runner.h" 12 #include "base/single_thread_task_runner.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "cc/paint/paint_surface.h"
14 #include "content/renderer/media/webmediaplayer_ms.h" 15 #include "content/renderer/media/webmediaplayer_ms.h"
15 #include "content/renderer/render_thread_impl.h" 16 #include "content/renderer/render_thread_impl.h"
16 #include "media/base/media_switches.h" 17 #include "media/base/media_switches.h"
17 #include "media/base/video_frame.h" 18 #include "media/base/video_frame.h"
18 #include "media/base/video_util.h" 19 #include "media/base/video_util.h"
19 #include "media/filters/video_renderer_algorithm.h" 20 #include "media/filters/video_renderer_algorithm.h"
20 #include "media/renderers/skcanvas_video_renderer.h" 21 #include "media/renderers/skcanvas_video_renderer.h"
21 #include "services/ui/public/cpp/gpu/context_provider_command_buffer.h" 22 #include "services/ui/public/cpp/gpu/context_provider_command_buffer.h"
22 #include "skia/ext/platform_canvas.h" 23 #include "skia/ext/platform_canvas.h"
23 #include "third_party/WebKit/public/platform/WebMediaStream.h" 24 #include "third_party/WebKit/public/platform/WebMediaStream.h"
(...skipping 16 matching lines...) Expand all
40 if (frame->HasTextures()) { 41 if (frame->HasTextures()) {
41 DCHECK(frame->format() == media::PIXEL_FORMAT_ARGB || 42 DCHECK(frame->format() == media::PIXEL_FORMAT_ARGB ||
42 frame->format() == media::PIXEL_FORMAT_XRGB || 43 frame->format() == media::PIXEL_FORMAT_XRGB ||
43 frame->format() == media::PIXEL_FORMAT_I420 || 44 frame->format() == media::PIXEL_FORMAT_I420 ||
44 frame->format() == media::PIXEL_FORMAT_UYVY || 45 frame->format() == media::PIXEL_FORMAT_UYVY ||
45 frame->format() == media::PIXEL_FORMAT_NV12); 46 frame->format() == media::PIXEL_FORMAT_NV12);
46 new_frame = media::VideoFrame::CreateFrame( 47 new_frame = media::VideoFrame::CreateFrame(
47 media::PIXEL_FORMAT_I420, frame->coded_size(), frame->visible_rect(), 48 media::PIXEL_FORMAT_I420, frame->coded_size(), frame->visible_rect(),
48 frame->natural_size(), frame->timestamp()); 49 frame->natural_size(), frame->timestamp());
49 50
50 sk_sp<SkSurface> surface = SkSurface::MakeRasterN32Premul( 51 sk_sp<cc::PaintSurface> surface = cc::PaintSurface::MakeRasterN32Premul(
51 frame->visible_rect().width(), frame->visible_rect().height()); 52 frame->visible_rect().width(), frame->visible_rect().height());
52 53
53 ui::ContextProviderCommandBuffer* const provider = 54 ui::ContextProviderCommandBuffer* const provider =
54 RenderThreadImpl::current()->SharedMainThreadContextProvider().get(); 55 RenderThreadImpl::current()->SharedMainThreadContextProvider().get();
55 if (surface && provider) { 56 if (surface && provider) {
56 DCHECK(provider->ContextGL()); 57 DCHECK(provider->ContextGL());
57 video_renderer->Copy( 58 video_renderer->Copy(
58 frame.get(), surface->getCanvas(), 59 frame.get(), surface->getCanvas(),
59 media::Context3D(provider->ContextGL(), provider->GrContext())); 60 media::Context3D(provider->ContextGL(), provider->GrContext()));
60 } else { 61 } else {
61 // Return a black frame (yuv = {0, 0x80, 0x80}). 62 // Return a black frame (yuv = {0, 0x80, 0x80}).
62 return media::VideoFrame::CreateColorFrame( 63 return media::VideoFrame::CreateColorFrame(
63 frame->visible_rect().size(), 0u, 0x80, 0x80, frame->timestamp()); 64 frame->visible_rect().size(), 0u, 0x80, 0x80, frame->timestamp());
64 } 65 }
65 66
66 SkPixmap pixmap; 67 SkPixmap pixmap;
67 const bool result = surface->getCanvas()->peekPixels(&pixmap); 68 const bool result = surface->getCanvas()->peekPixels(&pixmap);
68 DCHECK(result) << "Error trying to access SkSurface's pixels"; 69 DCHECK(result) << "Error trying to access PaintSurface's pixels";
69 70
70 const uint32 source_pixel_format = 71 const uint32 source_pixel_format =
71 (kN32_SkColorType == kRGBA_8888_SkColorType) ? libyuv::FOURCC_ABGR 72 (kN32_SkColorType == kRGBA_8888_SkColorType) ? libyuv::FOURCC_ABGR
72 : libyuv::FOURCC_ARGB; 73 : libyuv::FOURCC_ARGB;
73 libyuv::ConvertToI420( 74 libyuv::ConvertToI420(
74 static_cast<const uint8*>(pixmap.addr(0, 0)), 75 static_cast<const uint8*>(pixmap.addr(0, 0)),
75 pixmap.getSafeSize64(), 76 pixmap.getSafeSize64(),
76 new_frame->visible_data(media::VideoFrame::kYPlane), 77 new_frame->visible_data(media::VideoFrame::kYPlane),
77 new_frame->stride(media::VideoFrame::kYPlane), 78 new_frame->stride(media::VideoFrame::kYPlane),
78 new_frame->visible_data(media::VideoFrame::kUPlane), 79 new_frame->visible_data(media::VideoFrame::kUPlane),
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
452 } 453 }
453 454
454 if (!rendering_frame_buffer_) { 455 if (!rendering_frame_buffer_) {
455 rendering_frame_buffer_.reset(new media::VideoRendererAlgorithm( 456 rendering_frame_buffer_.reset(new media::VideoRendererAlgorithm(
456 base::Bind(&WebMediaPlayerMSCompositor::MapTimestampsToRenderTimeTicks, 457 base::Bind(&WebMediaPlayerMSCompositor::MapTimestampsToRenderTimeTicks,
457 base::Unretained(this)))); 458 base::Unretained(this))));
458 } 459 }
459 } 460 }
460 461
461 } // namespace content 462 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698