Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: components/ntp_snippets/content_suggestions_metrics_unittest.cc

Issue 2686063003: [remote suggestions] Attach the fetch time to RemoteSnippets, ContentSnippets and SnippetArticle (Closed)
Patch Set: rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_metrics_unittest.cc
diff --git a/components/ntp_snippets/content_suggestions_metrics_unittest.cc b/components/ntp_snippets/content_suggestions_metrics_unittest.cc
index 2424d503e8b683f4c15ec0d5a0dcbc954e2b688b..fe8193e300fe98e2a8e18cb0ec747ef785e63283 100644
--- a/components/ntp_snippets/content_suggestions_metrics_unittest.cc
+++ b/components/ntp_snippets/content_suggestions_metrics_unittest.cc
@@ -20,23 +20,21 @@ TEST(ContentSuggestionsMetricsTest, ShouldLogOnSuggestionsShown) {
base::HistogramTester histogram_tester;
OnSuggestionShown(/*global_position=*/1,
Category::FromKnownCategory(KnownCategories::ARTICLES),
- /*category_position=*/3,
- base::Time::Now(),
- base::Time::Now() - base::TimeDelta::FromHours(2),
- 0.01f);
+ /*category_position=*/3, base::Time::Now(), 0.01f,
+ base::Time::Now() - base::TimeDelta::FromHours(2));
// Test corner cases for score.
OnSuggestionShown(/*global_position=*/1,
Category::FromKnownCategory(KnownCategories::ARTICLES),
- /*category_position=*/3, base::Time::Now(),
- base::Time::Now() - base::TimeDelta::FromHours(2), 0.0f);
+ /*category_position=*/3, base::Time::Now(), 0.0f,
+ base::Time::Now() - base::TimeDelta::FromHours(2));
OnSuggestionShown(/*global_position=*/1,
Category::FromKnownCategory(KnownCategories::ARTICLES),
- /*category_position=*/3, base::Time::Now(),
- base::Time::Now() - base::TimeDelta::FromHours(2), 1.0f);
+ /*category_position=*/3, base::Time::Now(), 1.0f,
+ base::Time::Now() - base::TimeDelta::FromHours(2));
OnSuggestionShown(/*global_position=*/1,
Category::FromKnownCategory(KnownCategories::ARTICLES),
- /*category_position=*/3, base::Time::Now(),
- base::Time::Now() - base::TimeDelta::FromHours(2), 8.0f);
+ /*category_position=*/3, base::Time::Now(), 8.0f,
+ base::Time::Now() - base::TimeDelta::FromHours(2));
EXPECT_THAT(
histogram_tester.GetAllSamples(
« no previous file with comments | « components/ntp_snippets/content_suggestions_metrics.cc ('k') | components/ntp_snippets/remote/json_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698